Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump rust version to 1.84.0 #2607

Open
AurelienFT opened this issue Jan 21, 2025 · 4 comments
Open

Bump rust version to 1.84.0 #2607

AurelienFT opened this issue Jan 21, 2025 · 4 comments
Assignees
@AurelienFT

Comments

@AurelienFT
Copy link
Contributor

AurelienFT commented Jan 21, 2025 •
edited
Loading

In the same time revert : #2608
@AurelienFT AurelienFT mentioned this issue Jan 21, 2025
Merged
5 tasks
AurelienFT added a commit that referenced this issue Jan 21, 2025
@AurelienFT
Fix version compatibility error (#2608)
b6dbed4 
Fix in version compatibility, waiting for
#2607

## Checklist
- [x] Breaking changes are clearly marked as such in the PR description
and changelog
- [x] New behavior is reflected in tests
- [x] [The specification](https://github.com/FuelLabs/fuel-specs/)
matches the implemented behavior (link update PR if changes are needed)

### Before requesting review
- [x] I have reviewed the code myself
- [x] I have created follow-up issues caused by this PR and linked them
here
@Dentosal
Copy link
Member

Dentosal commented Feb 9, 2025

I'd also appreciate bumping rustfmt version at some point, the currently used nightly-2023-10-29 is getting a bit old. Although we might want to wait for Rust 1.85.0 for 2024 edition support.

@MitchTurner
Copy link
Member

Do we want to wait until after mainnet is updated? This is a breaking change.

@xgreenx
Copy link
Collaborator

xgreenx commented Feb 13, 2025

Our master already has many breaking changes, I think we can bump it

@AurelienFT
Copy link
Contributor Author

Let's goooo

@AurelienFT AurelienFT self-assigned this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AurelienFT AurelienFT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Dentosal @MitchTurner @xgreenx @AurelienFT