Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdRotator DataBinding features #210

Open
4 of 7 tasks
csharpfritz opened this issue Aug 23, 2020 · 8 comments
Open
4 of 7 tasks

AdRotator DataBinding features #210

csharpfritz opened this issue Aug 23, 2020 · 8 comments
Assignees
Labels
component-adrotator Issues related to the AdRotator enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed up-for-grabs Up for Grabs site participation

Comments

@csharpfritz
Copy link
Contributor

csharpfritz commented Aug 23, 2020

AdRotator needs to support the DataBinding features like:

  • DataSource
  • DataMember
  • DataBinding Events
  • AlternateTextField
  • ImageUrlField
  • NavigateUrlField
  • OnAdCreated
@csharpfritz csharpfritz added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed up-for-grabs Up for Grabs site participation labels Aug 23, 2020
@csharpfritz csharpfritz added this to the Complete for .NET Conf milestone Aug 23, 2020
@csharpfritz csharpfritz added the component-adrotator Issues related to the AdRotator label Aug 23, 2020
@hishamco
Copy link
Collaborator

I can work on this one ...

@csharpfritz
Copy link
Contributor Author

You got it @hishamco !

@hishamco
Copy link
Collaborator

@csharpfritz is there ability to edit your first thread so I can check the one that have been done while I'm working on

@hishamco
Copy link
Collaborator

hishamco commented Aug 24, 2020

I finished from the last 4 features, I will create another PR for DataBinding later on ...

@hishamco
Copy link
Collaborator

Just thinking about DataSource I think we should do similar to what we did when we bound DataTable to GridView. Regarding DataMember I don't think I used in the past so your thought @csharpfritz?

@hishamco
Copy link
Collaborator

@csharpfritz I start work to make AdRotator a DataBoundCompoment but the issue is both DataSource and DataMember are associate with DataSource controls in ASP.NET, so mark them as Obsolete may a better choice unless we need to bind it with DataTable but this need some efforts to map table columns to AdRotator properties

Your thoughts?

@csharpfritz
Copy link
Contributor Author

DataSourceID is used with DataSource controls in ASP.NET. DataSource and DataMember work with code-behind and DataBinding. Let's NOT mark those as Obsolete.

Agreed about rolling the same databinding interactions just completed for GridView to the other data bound controls

@hishamco
Copy link
Collaborator

DataSourceID is used with DataSource controls in ASP.NET.

Oops, just forgot that one ;)

Agreed about rolling the same databinding interactions just completed for GridView to the other data bound controls

Sounds good, but the issue here is based on the convention to map the AdRotator properties

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-adrotator Issues related to the AdRotator enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed up-for-grabs Up for Grabs site participation
Projects
None yet
Development

No branches or pull requests

2 participants