Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bypass DuckDuckGo icon lib #45

Open
AkarinLiu opened this issue Feb 13, 2025 · 1 comment
Open

Bypass DuckDuckGo icon lib #45

AkarinLiu opened this issue Feb 13, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@AkarinLiu
Copy link

AkarinLiu commented Feb 13, 2025

My Server Can`t Access DuckDuckGo icon lib, I hopely next update support get icon from source website.

@AkarinLiu AkarinLiu added the enhancement New feature or request label Feb 13, 2025
@clarkwinkelmann
Copy link
Member

This is not an easy fix.

Assuming you know the path to the favicon on the destination website, it would not be responsible to load it directly from the remote server, as you could involuntarily send a denial of service attack onto the destination website if your forum is more popular than the destination.

Another problem to a "simple" solution is that the path to the favicon cannot be guessed, so server-side logic is required to fetch the homepage, find the favicon URL, and refresh this information as time goes on.

Part of self-hosting the solution would require caching the icons. There are filesystem concerns with this (how big are the icons, how many will be stored), and along with fetching the homepage, this will leak the server IP to external websites, which might be undesirable.

The easiest fix would simply be to offer a choice for an alternative external icon proxy. I believe Google has one as well.

If there exists a self-hosted icon proxy script, there could be a setting in our extension to provide a custom URL to the self-hosted script. We would need to know what the URL syntax look like to automatically inject the destination website name in it.

Fixing #31 would likely be a pre-requirement to implement this, because any existing proxy URL currently gets permanently memorized, and a toggle for other than DuckDuckGo would have no impact on all links already created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants