Match Sybase dblib's handling of overlong or malformatted BCP input. #595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 3, 2024
Contributor
|
This change is weird. The conditions have a final |
Adjust existing failure modes' boundaries and introduce the possibility of proceeding with truncated input but reporting a message (20074, aka SYBEBCOR) as a middle ground between silent truncation and noisy failure. To that end, pass _bcp_convert_in the destination's length. Signed-off-by: Aaron M. Ucko <[email protected]>
ucko
force-pushed
the
ncbi-2024-05-convert-truncate
branch
from
231bbc1 to
c681ed0
Compare
Contributor
Author
Not sure what happened there, sorry; I suspect I wanted to take one last look at the old behavior and accidentally left the new logic switched off. I've pushed a corrected (and rebased) version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust existing failure modes' boundaries and introduce the possibility of proceeding with truncated input but reporting a message (20074, aka SYBEBCOR) as a middle ground between silent truncation and noisy failure. To that end, pass _bcp_convert_in the destination's length.