Skip to content

ct_connect: Set client_charset in addition to server_charset. #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ucko wants to merge 1 commit into from
Closed

ct_connect: Set client_charset in addition to server_charset. #574

ucko wants to merge 1 commit into from

Conversation

@ucko
Copy link
Contributor

@ucko ucko commented May 30, 2024

Split from #555.

@freddy77
Copy link
Contributor

freddy77 commented Jul 17, 2024

Not setting client_charset is done on purpose. This allows to pick up the server charset and convert properly on the client side.

@ucko
Copy link
Contributor Author

ucko commented Jul 18, 2024

Good point. FWIW, the original patch predated CS_CLIENTCHARSET support, and I hadn't registered the latter's availability.

@ucko ucko closed this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ucko @freddy77