Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add additional logging tags for protocol information #593

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rumpelsepp
Copy link
Member

@rumpelsepp rumpelsepp commented Sep 19, 2024

This MR adds the following; currently DRAFT for experiments:

  • standardize logging tags:
    • io={TYPE}; TYPE is either read or write
    • proto={PROTO}; PROTO is one of the supported protocols in gallia, e.g. uds or doip.
    • encoding={ENCODING}; optional; ENCODING could be hex or base64
  • add a dissector API
    • a dissector could be used in the hr commands to interpret the tagged messages

The motivation of this is, we have currently a "works somehow" dissector in cursed_hr for UDS. This dissector uses a best effort heuristic to detect UDS messages. However, this is not useful for messages of other types.

gallia recently gained FlexRay support and a standardized dissection API in our hr commands would help everybody. For instance, for FlexRay there is already an own tool to help debugging.

So, this MR is an attempt to standardize dissection in our toolchain by adding metadata to our logfiles and an extendable API for hr.

Open Questions:

  • API for dissector: How should protocol metadata be handled? e.g. FlexRay Slot ID or CAN IDs?

DRAFT to enable comprehensive dissecting in the `hr` commands.
@rumpelsepp rumpelsepp requested a review from peckto as a code owner September 19, 2024 12:37
@rumpelsepp rumpelsepp marked this pull request as draft September 19, 2024 12:38
@rumpelsepp rumpelsepp added this to the gallia 2.0 milestone Sep 19, 2024
@rumpelsepp rumpelsepp modified the milestones: gallia 2.0, gallia 2.1 Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant