Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cursed-hr): fallback to source dir if tmp dir not working #544

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

fkglr
Copy link
Contributor

@fkglr fkglr commented Jun 19, 2024

In case the tmp directory is too small (e.g. if in small RAM), decompressing large files fails.
This PR adds a fallback to creating a temporary file in the directory of the input file.

@rumpelsepp
Copy link
Member

rumpelsepp commented Jun 19, 2024

gallia conforms to the xdg standard. I would suggest to use $XDG_CACHE_HOME/gallia/filename for this. $XDG_CACHE_HOME falls back to ~/.cache.

This library is already a dependency. You can just use their user_cache_dir.

edit: gallia.log.PenlogReader might benefit from this change, too.

@fkglr fkglr force-pushed the cursed-tmp-file branch from 99acbeb to 12ac5eb Compare June 20, 2024 08:05
@fkglr fkglr merged commit dcfefe5 into master Jun 20, 2024
11 checks passed
@fkglr fkglr deleted the cursed-tmp-file branch June 20, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants