Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CAN Filter to deal with exended ids #185

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix CAN Filter to deal with exended ids #185

wants to merge 1 commit into from

Conversation

rumpelsepp
Copy link
Member

No description provided.

@rumpelsepp rumpelsepp requested a review from peckto as a code owner June 27, 2022 07:12
@rumpelsepp rumpelsepp changed the title wip Fix CAN Filter to deal with exended ids Jun 27, 2022
@rumpelsepp rumpelsepp marked this pull request as draft June 27, 2022 07:13
@rumpelsepp rumpelsepp added the bug Something isn't working label Jun 29, 2022
@rumpelsepp rumpelsepp added this to the v1.0.2 milestone Jun 29, 2022
@rumpelsepp rumpelsepp added the maint Needs cherry-picking to X.X-maint branch label Jun 29, 2022
@rumpelsepp rumpelsepp force-pushed the can-filter branch 2 times, most recently from ba10387 to ffaec60 Compare June 29, 2022 06:33
@rumpelsepp rumpelsepp marked this pull request as ready for review June 29, 2022 06:33
@rumpelsepp
Copy link
Member Author

@peckto Look again; I scheduled this into the next patch release as well.

@peckto
Copy link
Contributor

peckto commented Jun 29, 2022

Should we filter all extended IDs when not scanning in extended-id mode and the other way around?
Mixing up endpoints with normal IDs and extended IDs does not make sense to me anyway and the generated target URL will be flawed.

@rumpelsepp rumpelsepp modified the milestones: v1.0.2, v1.0.3, v1.0.4 Jun 30, 2022
@rumpelsepp rumpelsepp force-pushed the master branch 6 times, most recently from 72a5ecf to 41e0a13 Compare October 11, 2022 10:22
@rumpelsepp rumpelsepp force-pushed the master branch 2 times, most recently from 981f73a to 5218514 Compare October 25, 2022 09:04
@rumpelsepp rumpelsepp modified the milestones: v1.0.4, v1.2.0 Nov 2, 2022
@rumpelsepp rumpelsepp modified the milestones: v1.2.0, v1.3.0 Jul 10, 2023
@rumpelsepp rumpelsepp removed this from the v1.3.0 milestone Nov 15, 2023
@stale Stale
Copy link

stale bot commented Jul 14, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 14, 2024
@rumpelsepp rumpelsepp added this to the gallia 2.0 milestone Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peckto peckto peckto left review comments

Assignees
No one assigned
Labels
bug Something isn't working maint Needs cherry-picking to X.X-maint branch stale
Projects
None yet
Milestone
gallia 2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rumpelsepp @peckto