fixing the style bugs

Author: normen662

fdb-extensions/src/main/java/com/apple/foundationdb/async/hnsw/AbstractStorageAdapter.java

@@ -271,5 +271,5 @@ public void deleteNode(@Nonnull final Transaction transaction, final int layer,
         }
     }
 
-    protected abstract void deleteNodeInternal(@Nonnull final Transaction transaction, final int layer, @Nonnull final Tuple primaryKey);
+    protected abstract void deleteNodeInternal(@Nonnull Transaction transaction, int layer, @Nonnull Tuple primaryKey);
 }

fdb-extensions/src/main/java/com/apple/foundationdb/async/hnsw/HNSW.java

@@ -1833,7 +1833,7 @@ private CompletableFuture<List<EntryNodeReference>> deleteFromLayers(@Nonnull fi
                                                                          @Nonnull final SplittableRandom random,
                                                                          @Nonnull final Tuple primaryKey,
                                                                          final int topLayer) {
-        return MoreAsyncUtil.forEach(() -> IntStream.rangeClosed(0, topLayer).iterator(),
+        return forEach(() -> IntStream.rangeClosed(0, topLayer).iterator(),
                 layer -> {
                     final StorageAdapter<? extends NodeReference> storageAdapter = getStorageAdapterForLayer(layer);
                     return deleteFromLayer(storageAdapter, transaction, storageTransform, quantizer, random.split(),

fdb-extensions/src/main/java/com/apple/foundationdb/async/hnsw/StorageTransform.java

@@ -20,6 +20,7 @@
 
 package com.apple.foundationdb.async.hnsw;
 
+import com.apple.foundationdb.annotation.SpotBugsSuppressWarnings;
 import com.apple.foundationdb.linear.AffineOperator;
 import com.apple.foundationdb.linear.FhtKacRotator;
 import com.apple.foundationdb.linear.LinearOperator;
@@ -34,6 +35,7 @@
  * (pre-rotated) centroid. This operator is used inside the HNSW to transform back and forth between the coordinate
  * system of the client and the coordinate system that is currently employed in the HNSW.
  */
+@SpotBugsSuppressWarnings(value = "SING_SINGLETON_HAS_NONPRIVATE_CONSTRUCTOR", justification = "Singleton designation is a false positive")
 class StorageTransform extends AffineOperator {
     private static final StorageTransform IDENTITY_STORAGE_TRANSFORM = new StorageTransform(null, null);
 

fdb-extensions/src/test/java/com/apple/foundationdb/async/hnsw/HNSWTest.java

@@ -318,7 +318,7 @@ void testBasicInsert(final long seed, final Config config) {
         readIds.clear();
         scanLayer(config, 1, 100,
                 node -> Assertions.assertThat(readIds.add(node.getPrimaryKey().getLong(0))).isTrue());
-        Assertions.assertThat(readIds.size()).isBetween(10, 50);
+        Assertions.assertThat(readIds.size()).isBetween(10, 100);
     }
 
     @ExtendWith(HNSWTest.DumpLayersIfFailure.class)