Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make transparency of folders configurable #59

Closed

Conversation

FliegendeWurst
Copy link
Contributor

What is it?

  • Feature

Description of the changes in your PR

This PR makes the transparency of folders configurable. In my opinion the default is too opaque.

Before/After Screenshots/Screen Record

Screenshot_Transparency

  • Before (left): standard 10% transparency
  • After (right): 90% transparency

Alternatives

Make the default >70% transparency and do not add a configuration option.

Acknowledgement

@Aga-C
Copy link
Member

Aga-C commented Oct 26, 2024

Thanks for contributing, but next time please create an issue or discussion first (as stated in the contribution guidelines).

@naveensingh
Copy link
Member

I found a couple issues:

  • The whole preference option is not clickable and there is no ripple feedback.
  • The change isn't applied immediately. I have to restart the app for changes to take effect.
  • The preference should be located under the 'Home Screen' section. We don't have folders anywhere else.
  • The current name 'Transparency of folder background' is a bit wordy and works differently compared to other launcher apps. Let's rename it to 'Folder background opacity' where 0% means fully transparent and 100% means fully opaque.

@naveensingh naveensingh added the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Jan 1, 2025
@fossifybot
Copy link

This pull request has been automatically closed due to inactivity. We requested additional information but have not received a response from the original author. Without the requested details, we cannot proceed. If you have the needed information or updates, please reopen the PR or comment so we can continue the review.

@fossifybot fossifybot closed this Jan 16, 2025
@Aga-C Aga-C removed the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Jan 16, 2025
@FliegendeWurst
Copy link
Contributor Author

Okay with me. I have since switched to a darker background where the current opacity looks good enough.

I'll leave my branch up, in case someone else wants this feature and addresses the feedback above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants