Add simple GitHub action for static checks and tests #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@esensar this looks ready to be merged. Is it ready to be merged? |
|
All checks have passed 🚀 |
|
I responded in https://github.com/orgs/FossifyOrg/discussions/83, but for visibility, I will also reapond here. I thought we could iron the workflow out here (as much as we can at this stage, there will probably be changes in the future) and then just copy it over to other repos when done. |
Enabled android lint, added detekt and created github workflow for PRs. Related to discussion: https://github.com/orgs/FossifyOrg/discussions/83
|
I think this is done for now. App is built and uploaded as actions artifact. That download link is maybe not very visible, so it may be good to add another job to post a comment on PR once APK is uploaded. Other than that, we could consider not building APKs for all changes and all PRs, but maybe we can refine that later on. |
naveensingh
added
the
testers needed
naveensingh
reviewed
Jan 26, 2024
naveensingh
reviewed
Jan 26, 2024
|
Thank you :) |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled android lint, added detekt and created github workflow for PRs.
Related to discussion: https://github.com/orgs/FossifyOrg/discussions/83