Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't delete pre-existing event type #373

Closed
7 tasks done
T0mstone opened this issue Nov 13, 2024 · 3 comments
Closed
7 tasks done

Can't delete pre-existing event type #373

T0mstone opened this issue Nov 13, 2024 · 3 comments
Labels
duplicate This issue or pull request already exists

Comments

@T0mstone
Copy link
Contributor

Checklist

  • I can reproduce the bug with the latest version given here.
  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected app version

1.0.3

Affected Android/Custom ROM version

Android 14 / LineageOS 21

Affected device model

Fairphone 3+

How did you install the app?

F-Droid / IzzyOnDroid

Steps to reproduce the bug

  1. Go to the 'Settings > Manage Event types' and add a new event type
  2. Go to 'Settings > New Events > Default event type' and change it to the newly created one
  3. Go back to 'Settings > Manage Event types' , click on '…' for the previously existing event type (I think the default name was "Recurring Event") and click "Delete"

Expected behavior

The selected event type is deleted.

Actual behavior

A popup says "Default event type cannot be deleted"

Screenshots/Screen recordings

No response

Additional information

The device is rooted (but I doubt that is relevant to this issue).

@T0mstone T0mstone added bug Something is not working needs triage Issue is not yet ready for PR authors to take up labels Nov 13, 2024
@Aga-C
Copy link
Member

Aga-C commented Nov 13, 2024

See: #150 (comment).

@Aga-C Aga-C closed this as not planned Won't fix, can't repro, duplicate, stale Nov 13, 2024
@Aga-C Aga-C added duplicate This issue or pull request already exists invalid This does not seem right and removed bug Something is not working needs triage Issue is not yet ready for PR authors to take up labels Nov 13, 2024
@T0mstone
Copy link
Contributor Author

Hm, I feel like this is an unnecessary technical limitation. You should at least be able to change which of the existing event types is the fallback (even if it has to be a separate thing from the "default event type").

I won't ask that of you, but would you mind if I try implementing it myself and open a PR if I get something done?

@Aga-C
Copy link
Member

Aga-C commented Nov 14, 2024

@T0mstone #150 (comment)

@Aga-C Aga-C removed the invalid This does not seem right label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants