long click->new Event on day in month view

[gitmacer]

What is it?

• Bugfix
• Feature
• Codebase improvement

Description of the changes in your PR

• Long press on day will open new appointment UI

I choosed to open the event UI instead of the task/event selection popup because of the improved workflow. That is the mostly wanted option and you can still use the + button to add tasks. (being able to choose even/popup in the settings could be useful)

Before/After Screenshots/Screen Record

• After:
  Screen_recording_20240321_210749.webm

Fixes the following issue(s)

• Fixes Long press on Day in Month view for new appointment #182

Acknowledgement

• I read the contribution guidelines.

[Aga-C]

It should work the same as adding events in weekly view - it should display a popup for choosing between events and task if Allow creating tasks is enabled in Settings.

[gitmacer]

It should work the same as adding events in weekly view - it should display a popup for choosing between events and task if Allow creating tasks is enabled in Settings.

ok I will look into it.

[gitmacer]

@Aga-C can you take another look and test it?
I think we should implement custom longclick logic to make sure it dosn't get triggered by accident when touching but scolling after some time.
default OnLongClick:
trigger after 400ms without scrolling within the time

What I suggest:
Trigger after releasing after atleast 500ms without scrolling in the mean time.
(vibrate after 400ms to indecate longclick got registered)

what do you think about that?

[Aga-C]

I think we should implement custom longclick logic to make sure it dosn't get triggered by accident when touching but scolling after some time.

Can you actually do this when normally using the app? When I scroll horizontally, it never happened to me. Just when I did it very slow, that I barely moved a finger, it triggered the new event popup. It looks like when the next view even barely appears on the screen, the long press event is cancelled.

However, I see two another minor problems:

• There's an animation while opening a popup. It comes visibly from the bottom when in weekly view it just appears in place. In my opinion, behavior between two views should be consistent.
• If you have event type filtered out in a quick filters list on the bottom, after closing the popup (without selecting anything) these disabled event types quickly blink.

[gitmacer]

@Aga-C should be fixed now.

I am just a little bit concerned that especially older people will accidently triggering it demo:
https://youtube.com/shorts/zFefjXy_qsA

But after creating it I admit it feels a little bit unusual. Maybe a simple option to disable it is even better. Others opinions wanted.
https://github.com/gitmacer/Calendar/tree/LongClickReleaseForNew

[Aga-C]

For now, let's leave it as it is. We'll think about it.

[gitmacer]

For now, let's leave it as it is. We'll think about it.

That means you will merge with long press auto popup?
Or you will think about the options and decide soon? (longer longpress time, longpress on release or option to Enable/Disable)?

[Aga-C]

I can't merge, but until Naveen will have time to check the PR, maybe we will get to some conclusion how to approach it.

[gitmacer]

I can't merge, but until Naveen will have time to check the PR, maybe we will get to some conclusion how to approach it.

ok sounds good. Btw can you also check #181

[naveensingh]

Merging for now, we'll increase the long press timeout after someone reports this feature as a bug :)

[gitmacer]

Merging for now, we'll increase the long press timeout after someone reports this feature as a bug :)

I noticed that is actually a device and setting depending delay so.
My phone had it on pretty low by default.
If it is a problem we could tell them to change that setting.

I am happy you liked my addition sadly currently I got pretty limited in posebilities.

But hope it will solve soon.