Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-defined style fontFamily breaks Prism theme #319

Open
gutenye opened this issue Apr 26, 2022 · 0 comments
Open

pre-defined style fontFamily breaks Prism theme #319

gutenye opened this issue Apr 26, 2022 · 0 comments

Comments

@gutenye
Copy link

gutenye commented Apr 26, 2022

Line 51 fontFamily: "inherit"

margin: 0,
outline: "none",
padding: 10,
fontFamily: "inherit",

Will override Prism theme

https://github.com/PrismJS/prism/blob/0d4b6cb64e72a172fc64423c04aed4ac8b59cd0b/themes/prism.css#L12

Further, why not let users define all the style (margin, outline, padding, fontFamily) by themself through className? This way, React Live will become a true HeadlessUI component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant