Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate code to install ncr #8

Open
jaromil opened this issue Feb 10, 2025 · 1 comment
Open

Duplicate code to install ncr #8

jaromil opened this issue Feb 10, 2025 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@jaromil
Copy link
Member

jaromil commented Feb 10, 2025

The ncr installation is already handled by the makefile of tf-pqcrypto-scripts whose repo is cloned right after this line: https://github.com/ForkbombEu/tf-pqcrypto-scripts/blob/main/Makefile

It is best to avoid duplication and use the Makefile of tf-pqcrypt-scripts also in the .tf so that whenever we'll need to fix it we have just one place to edit.

@jaromil jaromil added the enhancement New feature or request label Feb 10, 2025
@g7240
Copy link
Collaborator

g7240 commented Feb 10, 2025

At the moment the tf-pqcrypto-scripts repository is only used to get contracts. ncr is managed via the setup script user-data.sh because in EC2 it is necessary to make the ncr startup persistent when the system reboot; now we are doing it via systemctl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants