-
Notifications
You must be signed in to change notification settings - Fork 2
SDKS-4193: Protect collector e2e tests #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
View your CI Pipeline Execution ↗ for commit e85fc69
☁️ Nx Cloud last updated this comment at |
Deployed b2c7ef8 to https://ForgeRock.github.io/ping-javascript-sdk/pr-346/b2c7ef83fb942e3759a195edadb1b634031018fe branch gh-pages in ForgeRock/ping-javascript-sdk |
📦 Bundle Size Analysis📦 Bundle Size Analysis➖ No Changes➖ @pingidentity/protect - 108.3 KB 11 packages analyzed • Baseline from latest Legend🆕 New package ℹ️ How bundle sizes are calculated
🔄 Updated automatically on each push to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than my one comment, which applies to both tests, this looks great.
|
||
await page.getByRole('button', { name: 'Sign On' }).click(); | ||
|
||
await expect( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only complaint about this single test is that we not entirely sure a proper payload was sent to the server. Maybe the server failed because of missing payload? Should we add a assertion that tests that we sent a payload that has predictable attributes, like length of string or the start of the string always has some combination of characters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. The SDK should actually error before data is sent to the server if the protect payload is missing or not a string. This would be a good way to test that. Will add something that checks if the string starts with R/o
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
ffa41b1
to
e85fc69
Compare
JIRA Ticket
https://pingidentity.atlassian.net/browse/SDKS-4193
Description
No changeset