chore(protect): pr revisions

Author: ancheetah

packages/protect/src/lib/protect.test.ts

@@ -29,7 +29,6 @@ describe('protect', () => {
     disableTags: false,
     disableHub: false,
   };
-  let protectAPI: Protect | undefined;
 
   async function getProtect(options: ProtectConfig): Promise<Protect> {
     const protectAPI: Protect = await protect(options);
@@ -61,8 +60,6 @@ describe('protect', () => {
       pauseBehavioralData: vi.fn(),
       resumeBehavioralData: vi.fn(),
     };
-
-    protectAPI = await getProtect(config);
   });
 
   afterEach(() => {
@@ -76,90 +73,99 @@ describe('protect', () => {
   });
 
   it('should return protect methods', async () => {
-    expect(protectAPI?.start).toBeDefined();
-    expect(protectAPI?.getData).toBeDefined();
-    expect(protectAPI?.pauseBehavioralData).toBeDefined();
-    expect(protectAPI?.resumeBehavioralData).toBeDefined();
-    expect(protectAPI?.getPauseBehavioralData).toBeDefined();
-    expect(protectAPI?.getNodeConfig).toBeDefined();
-    expect(protectAPI?.getProtectType).toBeDefined();
-    expect(protectAPI?.setNodeClientError).toBeDefined();
-    expect(protectAPI?.setNodeInputValue).toBeDefined();
+    const protectAPI = await getProtect(config);
+    expect(protectAPI.start).toBeDefined();
+    expect(protectAPI.getData).toBeDefined();
+    expect(protectAPI.pauseBehavioralData).toBeDefined();
+    expect(protectAPI.resumeBehavioralData).toBeDefined();
+    expect(protectAPI.getPauseBehavioralData).toBeDefined();
+    expect(protectAPI.getNodeConfig).toBeDefined();
+    expect(protectAPI.getProtectType).toBeDefined();
+    expect(protectAPI.setNodeClientError).toBeDefined();
+    expect(protectAPI.setNodeInputValue).toBeDefined();
   });
 
   it('should error on failed signals sdk load', async () => {
-    protectAPI = undefined;
     vi.doUnmock('./signals-sdk.js');
     await expect(protect(config)).rejects.toThrowError('Failed to load PingOne Signals SDK');
   });
 
   it('should call start', async () => {
-    const protectMock = protectAPI && vi.spyOn(protectAPI, 'start');
-    await protectAPI?.start();
+    const protectAPI = await getProtect(config);
+    const protectMock = vi.spyOn(protectAPI, 'start');
+    await protectAPI.start();
     expect(protectMock).toHaveBeenCalled();
     expect(window._pingOneSignals.init).toHaveBeenCalledWith(config);
   });
 
   it('should call getData', async () => {
-    const protectMock = protectAPI && vi.spyOn(protectAPI, 'getData');
-    await protectAPI?.getData();
+    const protectAPI = await getProtect(config);
+    const protectMock = vi.spyOn(protectAPI, 'getData');
+    await protectAPI.getData();
     expect(protectMock).toHaveBeenCalled();
   });
 
   it('should call pauseBehavioralData', async () => {
-    const protectMock = protectAPI && vi.spyOn(protectAPI, 'pauseBehavioralData');
-    protectAPI?.pauseBehavioralData();
+    const protectAPI = await getProtect(config);
+    const protectMock = vi.spyOn(protectAPI, 'pauseBehavioralData');
+    protectAPI.pauseBehavioralData();
     expect(protectMock).toHaveBeenCalled();
   });
 
   it('should call resume behavioralData', async () => {
-    const protectMock = protectAPI && vi.spyOn(protectAPI, 'resumeBehavioralData');
-    protectAPI?.resumeBehavioralData();
+    const protectAPI = await getProtect(config);
+    const protectMock = vi.spyOn(protectAPI, 'resumeBehavioralData');
+    protectAPI.resumeBehavioralData();
     expect(protectMock).toHaveBeenCalled();
   });
 
   describe('should test the marketplace node setup', () => {
-    it('should test getPauseBehavioralData with marketplace data', () => {
-      const result = protectAPI?.getPauseBehavioralData(standardPingProtectEvaluationStep);
+    it('should test getPauseBehavioralData with marketplace data', async () => {
+      const protectAPI = await getProtect(config);
+      const result = protectAPI.getPauseBehavioralData(standardPingProtectEvaluationStep);
       expect(result).toEqual(false);
 
       const secondResult = protectAPI?.getPauseBehavioralData(standardPingProtectInitializeStep);
       expect(secondResult).toEqual(true);
     });
 
-    it('should get the node config', () => {
-      const result = protectAPI?.getNodeConfig(standardPingProtectInitializeStep);
+    it('should get the node config', async () => {
+      const protectAPI = await getProtect(config);
+      const result = protectAPI.getNodeConfig(standardPingProtectInitializeStep);
       expect(result).toEqual(
         // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
         standardPingProtectInitializeStep!.payload.callbacks![0].output[0].value,
       );
 
-      const result2 = protectAPI?.getNodeConfig(noProtectType);
+      const result2 = protectAPI.getNodeConfig(noProtectType);
       expect(result2).toBeUndefined();
     });
 
-    it('should test the getPingProtectType method', () => {
-      const result = protectAPI?.getProtectType(standardPingProtectInitializeStep);
+    it('should test the getPingProtectType method', async () => {
+      const protectAPI = await getProtect(config);
+      const result = protectAPI.getProtectType(standardPingProtectInitializeStep);
       expect(result).toEqual('initialize');
 
-      const result2 = protectAPI?.getProtectType(standardPingProtectEvaluationStep);
+      const result2 = protectAPI.getProtectType(standardPingProtectEvaluationStep);
       expect(result2).toEqual('evaluate');
 
-      const result3 = protectAPI?.getProtectType(noProtectType);
+      const result3 = protectAPI.getProtectType(noProtectType);
       expect(result3).toEqual('none');
     });
 
-    it('should set the input with marketplace nodes', () => {
+    it('should set the input with marketplace nodes', async () => {
+      const protectAPI = await getProtect(config);
       const step = standardPingProtectEvaluationStep as FRStep;
 
-      protectAPI?.setNodeInputValue(step, 'the value');
+      protectAPI.setNodeInputValue(step, 'the value');
       const [hc] = step.getCallbacksOfType<HiddenValueCallback>(CallbackType.HiddenValueCallback);
 
       expect(hc.getInputValue()).toEqual('the value');
     });
 
-    it('should set an error with marketplace nodes', () => {
-      protectAPI?.setNodeClientError(standardPingProtectEvaluationStep, 'we errored!');
+    it('should set an error with marketplace nodes', async () => {
+      const protectAPI = await getProtect(config);
+      protectAPI.setNodeClientError(standardPingProtectEvaluationStep, 'we errored!');
 
       const [, err] = (
         standardPingProtectEvaluationStep as FRStep