Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Should Return 404 when deleting a non-existing variable or chatflow #3221

Open
Cyberschorsch opened this issue Sep 19, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@Cyberschorsch
Copy link

Describe the bug
I am currently writing a implementation for the Flowise API and the endpoints in my Flowise application always return status code 200 when passing a valid Bearer Token for requests I would expect a 404 or something similar.

When passing no Auth Token the API returns an expected 401 for those resources.

This is consistent with curl requests as well as other tools and different instances.

For example: Deleting a non-existing variable or chatflow

To Reproduce
Steps to reproduce the behavior:

  1. Create a valid Auth Token
  2. Try to delete a non-existing variable

Expected behavior

The endpoint returns a 404 for the request.

Screenshots
Bildschirmfoto vom 2024-09-19 16-18-38
Bildschirmfoto vom 2024-09-19 16-18-59
Bildschirmfoto vom 2024-09-19 16-26-10

Setup

  • Installation [docker]
  • Flowise Version [2.1.0]
  • OS: [Linux]
  • CORS-Origins: *

Additional context
Add any other context about the problem here.

@HenryHengZJ
Copy link
Contributor

Yes i agree we should return 404 when chatflow/tool/agent doesnt exists. For now you can have additional check of the response affected to see how many got deleted

@HenryHengZJ HenryHengZJ added the enhancement New feature or request label Sep 19, 2024
@HenryHengZJ HenryHengZJ changed the title [BUG] API-Endpoint always returns 200 for authenticated requests? [BUG] Should Return 404 when deleting a non-existing variable or chatflow Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants