Skip to content

#4378 Migrate StoredKeyInfo to KeyInfoWithIdentity format #5976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ioanmo226
Copy link
Collaborator

@ioanmo226 ioanmo226 commented Apr 14, 2025

This PR migrates StoredKeyInfo to KeyInfoWithIdentity format

close #4378 // if this PR closes an issue


Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@ioanmo226 ioanmo226 marked this pull request as ready for review April 14, 2025 01:48
@ioanmo226 ioanmo226 requested a review from sosnovsky as a code owner April 14, 2025 01:48
@ioanmo226
Copy link
Collaborator Author

Is this something @tomholub wanted?

Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great 👍

@sosnovsky sosnovsky merged commit aa42a1a into master Apr 16, 2025
12 checks passed
@sosnovsky sosnovsky deleted the 4378-migrate-acctstoragekeys-to-have-keyinfowithidentity-instead-of-keyinfo branch April 16, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate AcctStorage[keys] to have KeyInfoWithIdentity instead of KeyInfo
2 participants