Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md - Library imports #67

Open
lgleznah opened this issue May 4, 2020 · 0 comments
Open

README.md - Library imports #67

lgleznah opened this issue May 4, 2020 · 0 comments

Comments

@lgleznah
Copy link

lgleznah commented May 4, 2020

Good morning.

I write this issue because I've had some trouble getting the library to work. The thing is, in the main README file, there is this piece of code:

// This will be all that you need
import io.radicalbit.flink.pmml.scala._

import org.apache.flink.ml.math.Vector
import org.apache.flink.streaming.api.scala._

object FlinkJpmmlExample {
  def main(args: Array[String]): Unit = {

    // your model can reside in any Flink supported backend
    val pathToPmml = "/even/to/distributed/systems"

    val env = StreamExecutionEnvironment.getExecutionEnvironment
    val events = env.yourInputStream

    //  a lazy reader implementation
    val reader = ModelReader(pathToPmml)

However, I couldn't get this piece of code to work. After searching through the repo, I found that an additional import was required:

import io.radicalbit.flink.pmml.scala.api.reader.ModelReader

Could this import be added to the README example? I know it's already in the examples, but not having it in the main README file could be misleading.

For reference, I tried this on an Ubuntu 18.04 VM, working with Flink 1.9.0 and Scala 2.11.12, compiled with sbt 1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant