Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the SDK Async-friendly #59

Open
dabeeeenster opened this issue Sep 5, 2023 · 1 comment
Open

Make the SDK Async-friendly #59

dabeeeenster opened this issue Sep 5, 2023 · 1 comment

Comments

@dabeeeenster
Copy link
Contributor

If folk want to use this SDK in an async/non-blocking environment like FastAPI they will not have a good time. We should move to using async-friendly libraries.
@tushar5526
Copy link
Contributor

I like how sync and async clients are created in encode/httpx https://github.com/encode/httpx/blob/master/httpx/_client.py. Something similar can be used here, the only thing concerning would be a lot of duplicated codes, doc strings for Sync and async clients, but I don't think there are any workarounds for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dabeeeenster @tushar5526