Require exactly correct page size in DPB when creating database, reject wrong values [CORE6510]

[firebird-automations]

Submitted by: @AlexPeshkoff

Depends on CORE6503

Currently FB accepts any numeric noise as valid page size, rounding it down (or up in case of small values) to the nearest correct page size. That behavior appera s to be very suspicious - looks like it may cause only problems.

Also would be good idea to detect (on client) garbage passed as page size which is currently treated as default page size.

[firebird-automations]

Modified by: @AlexPeshkoff

assignee: Alexander Peshkov [ alexpeshkoff ]

[firebird-automations]

Modified by: @AlexPeshkoff

Link: This issue depends on CORE6503 [ CORE6503 ]

[firebird-automations]

Modified by: @AlexPeshkoff

Fix Version: 4.1 Initial [ 10961 ]

Fix Version: 5.0 Initial [ 10962 ]

[firebird-automations]

Commented by: @mrotteveel

The rounding up for values smaller than 4096 is - I assume - for backwards compatibility with scripts that used 1024 or 2048. Also, keep in mind that this is documented behaviour (see https://firebirdsql.org/file/documentation/html/en/refdocs/fblangref25/firebird-25-language-reference.html#fblangref25-ddl-db-createdbopts), though that is mostly 'documenting how it actually works'.

[firebird-automations]

Modified by: @AlexPeshkoff

description: Currently FB accepts any numeric noise as valid page size, rounding it down (or up in case of small values) to the nearest correct page size. That behavior appera s to be very suspicious - looks like it may cause only problems. => Currently FB accepts any numeric noise as valid page size, rounding it down (or up in case of small values) to the nearest correct page size. That behavior appera s to be very suspicious - looks like it may cause only problems.

Also would be good idea to detect (on client) garbage passed as page size which is currently treated as default page size.

[firebird-automations]

Commented by: @AlexPeshkoff

Yes Mark - I think keeping a rule that correct (power of 2) but too small values are treated as minimum available size is good idea.