From 17ba7b37c4a2a14c704a049c1ede872dd2bcbc04 Mon Sep 17 00:00:00 2001 From: galeza Date: Fri, 13 Nov 2020 12:14:42 +0100 Subject: [PATCH 1/8] Add review build url --- .github/workflows/review-build-url.yml | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 .github/workflows/review-build-url.yml diff --git a/.github/workflows/review-build-url.yml b/.github/workflows/review-build-url.yml new file mode 100644 index 0000000..0e3a811 --- /dev/null +++ b/.github/workflows/review-build-url.yml @@ -0,0 +1,22 @@ + +name: Post Review Build URL to PR +on: + pull_request: + types: [opened] +jobs: + example: + name: Post to PR + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + - id: get-branch-name-sanitized + name: Sanitize branch name + shell: bash + run: echo "::set-output name=branch::$(jq --raw-output .pull_request.head.ref "$GITHUB_EVENT_PATH" | tr -cd '[a-zA-Z0-9]-' | cut -b 1-40)" + - name: Post Review Build URL + if: startsWith(steps.get-branch-name-sanitized.outputs.branch, 'feature') + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + with: + msg: "Branch name is correct" + check_for_duplicate_msg: true From d620c41100995435d7ed46942b387c74d9a11a82 Mon Sep 17 00:00:00 2001 From: galeza Date: Fri, 13 Nov 2020 12:48:25 +0100 Subject: [PATCH 2/8] Correct review-build-url.yml --- .github/workflows/review-build-url.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/review-build-url.yml b/.github/workflows/review-build-url.yml index 0e3a811..80f82e1 100644 --- a/.github/workflows/review-build-url.yml +++ b/.github/workflows/review-build-url.yml @@ -14,7 +14,8 @@ jobs: shell: bash run: echo "::set-output name=branch::$(jq --raw-output .pull_request.head.ref "$GITHUB_EVENT_PATH" | tr -cd '[a-zA-Z0-9]-' | cut -b 1-40)" - name: Post Review Build URL - if: startsWith(steps.get-branch-name-sanitized.outputs.branch, 'feature') + if: startsWith(steps.get-branch-name-sanitized.outputs.branch, 'feature') + uses: unsplash/comment-on-pr@master env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: From c98625e2483ab0128790f45d88d08f3c7ac29bd2 Mon Sep 17 00:00:00 2001 From: galeza Date: Fri, 13 Nov 2020 12:52:33 +0100 Subject: [PATCH 3/8] Add branch name --- .github/workflows/review-build-url.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/review-build-url.yml b/.github/workflows/review-build-url.yml index 80f82e1..4ed823e 100644 --- a/.github/workflows/review-build-url.yml +++ b/.github/workflows/review-build-url.yml @@ -4,9 +4,9 @@ on: pull_request: types: [opened] jobs: - example: - name: Post to PR + branch_name: runs-on: ubuntu-latest + name: Branch Name steps: - uses: actions/checkout@v2 - id: get-branch-name-sanitized From 2083b0a73350ca838479af289c8c9f1a12ceb8d8 Mon Sep 17 00:00:00 2001 From: galeza Date: Fri, 13 Nov 2020 12:55:05 +0100 Subject: [PATCH 4/8] Change steps --- .github/workflows/review-build-url.yml | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/.github/workflows/review-build-url.yml b/.github/workflows/review-build-url.yml index 4ed823e..aa5e6d5 100644 --- a/.github/workflows/review-build-url.yml +++ b/.github/workflows/review-build-url.yml @@ -9,15 +9,9 @@ jobs: name: Branch Name steps: - uses: actions/checkout@v2 - - id: get-branch-name-sanitized - name: Sanitize branch name - shell: bash - run: echo "::set-output name=branch::$(jq --raw-output .pull_request.head.ref "$GITHUB_EVENT_PATH" | tr -cd '[a-zA-Z0-9]-' | cut -b 1-40)" - - name: Post Review Build URL - if: startsWith(steps.get-branch-name-sanitized.outputs.branch, 'feature') - uses: unsplash/comment-on-pr@master - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: - msg: "Branch name is correct" - check_for_duplicate_msg: true + branch_pattern: 'feature' + comment_for_invalid_branch_name: 'This branch name is not following the standards!' + fail_if_invalid_branch_name: 'true' + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From 97a3b08a02ae8e765d0f48e80adf2d6d44d6719c Mon Sep 17 00:00:00 2001 From: galeza Date: Fri, 27 Nov 2020 13:43:33 +0100 Subject: [PATCH 5/8] Correct workflow --- .github/workflows/review-build-url.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/review-build-url.yml b/.github/workflows/review-build-url.yml index aa5e6d5..61e5644 100644 --- a/.github/workflows/review-build-url.yml +++ b/.github/workflows/review-build-url.yml @@ -11,7 +11,7 @@ jobs: - uses: actions/checkout@v2 with: branch_pattern: 'feature' - comment_for_invalid_branch_name: 'This branch name is not following the standards!' + comment_for_invalid_branch_name: 'This branch name is not following the standards. Name should start with feature/' fail_if_invalid_branch_name: 'true' env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From 74eead82df1d953e144df1a70f7acf0aa74b935f Mon Sep 17 00:00:00 2001 From: galeza Date: Fri, 27 Nov 2020 13:54:20 +0100 Subject: [PATCH 6/8] Add second version --- .github/workflows/review-build-url-v2.yml | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 .github/workflows/review-build-url-v2.yml diff --git a/.github/workflows/review-build-url-v2.yml b/.github/workflows/review-build-url-v2.yml new file mode 100644 index 0000000..2f182a6 --- /dev/null +++ b/.github/workflows/review-build-url-v2.yml @@ -0,0 +1,20 @@ +name: Post Review Build URL to PR +on: + pull_request: + types: [opened] +jobs: + example: + name: Post to PR + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + - id: get-branch-name-sanitized + name: Sanitize branch name + shell: bash + run: echo "::set-output name=branch::$(jq --raw-output .pull_request.head.ref "$GITHUB_EVENT_PATH" | tr -cd '[a-zA-Z0-9]-' | cut -b 1-40)" + - name: Post Review Build URL + if: startsWith(steps.get-branch-name-sanitized.outputs.branch, 'feature') + uses: unsplash/comment-on-pr@master + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + From d6fda0b52aa5691dac9a315a660bcf9addf6d0d0 Mon Sep 17 00:00:00 2001 From: galeza Date: Fri, 27 Nov 2020 14:03:32 +0100 Subject: [PATCH 7/8] Add message --- .github/workflows/review-build-url-v2.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/review-build-url-v2.yml b/.github/workflows/review-build-url-v2.yml index 2f182a6..0a0040e 100644 --- a/.github/workflows/review-build-url-v2.yml +++ b/.github/workflows/review-build-url-v2.yml @@ -17,4 +17,6 @@ jobs: uses: unsplash/comment-on-pr@master env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - + with: + msg: "Sanitize branch name" + check_for_duplicate_msg: true From be31f8a4d1173dd9209dde948a5ddde306a8be54 Mon Sep 17 00:00:00 2001 From: galeza Date: Fri, 27 Nov 2020 14:06:31 +0100 Subject: [PATCH 8/8] Add message --- .github/workflows/review-build-url-v2.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/review-build-url-v2.yml b/.github/workflows/review-build-url-v2.yml index 0a0040e..4d7d21d 100644 --- a/.github/workflows/review-build-url-v2.yml +++ b/.github/workflows/review-build-url-v2.yml @@ -18,5 +18,5 @@ jobs: env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: - msg: "Sanitize branch name" + msg: "Branch name is correct" check_for_duplicate_msg: true