Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite populateHTML #48

Open
Fertogo opened this issue Apr 28, 2015 · 1 comment
Open

Rewrite populateHTML #48

Fertogo opened this issue Apr 28, 2015 · 1 comment
Labels
OWM

Comments

@Fertogo
Copy link
Owner

Fertogo commented Apr 28, 2015

Clearly, I didn't know about templates when I first wrote populateHTML. This function is not ready for change. I propose making a template and .clone() ing and then edit specific values from there. (See Email annoyer repo main.js for an example).

There are other parts of the code where I do this, but populateHTML is definitely the worst.
@Fertogo Fertogo added the OWM label Apr 28, 2015
@Fertogo
Copy link
Owner Author

Fertogo commented May 22, 2015

It might not be worth it to do this in jQuery since I may want to rewrite the front end in Angular for the future.

@Fertogo Fertogo removed this from the Pebble Workout Timer v3.2 milestone May 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OWM
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Fertogo