Skip to content

Commit 61ea671

Browse files
authored
Merge pull request #1009 from k163377/porting-tests
Add exhaustive tests for JsonValue and JsonKey usage in value class
2 parents 4f69cfa + 605e34c commit 61ea671

File tree

10 files changed

+522
-0
lines changed

10 files changed

+522
-0
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
package com.fasterxml.jackson.module.kotlin.kogeraIntegration.ser.valueClass.jsonKey
2+
3+
import com.fasterxml.jackson.annotation.JsonKey
4+
import com.fasterxml.jackson.module.kotlin.defaultMapper
5+
import org.junit.jupiter.api.Assertions.assertEquals
6+
import org.junit.jupiter.api.Test
7+
8+
class NonNullObjectTest {
9+
@JvmInline
10+
value class NonNull(val v: String) {
11+
@JsonKey
12+
fun jsonValue() = v + "_modified"
13+
}
14+
15+
@Test
16+
fun nonNullTest() {
17+
assertEquals(
18+
"""{"test_modified":null}""",
19+
defaultMapper.writeValueAsString(mapOf(NonNull("test") to null)),
20+
)
21+
}
22+
23+
@JvmInline
24+
value class Nullable(val v: String) {
25+
@JsonKey
26+
fun jsonValue() = v.takeIf { it.length % 2 == 0 }?.let { it + "_modified" }
27+
}
28+
29+
// The case of returning null as a key is unnecessary because it will result in an error
30+
@Test
31+
fun nullableTest() {
32+
assertEquals(
33+
"""{"test_modified":null}""",
34+
defaultMapper.writeValueAsString(mapOf(Nullable("test") to null)),
35+
)
36+
}
37+
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
package com.fasterxml.jackson.module.kotlin.kogeraIntegration.ser.valueClass.jsonKey
2+
3+
import com.fasterxml.jackson.annotation.JsonKey
4+
import com.fasterxml.jackson.module.kotlin.defaultMapper
5+
import org.junit.jupiter.api.Assertions.assertEquals
6+
import org.junit.jupiter.api.Test
7+
8+
class NullableObjectTest {
9+
@JvmInline
10+
value class Value(val v: String?) {
11+
@JsonKey
12+
fun jsonValue() = v?.let { it + "_modified" }
13+
}
14+
15+
// The case of returning null as a key is unnecessary because it will result in an error
16+
@Test
17+
fun test() {
18+
assertEquals(
19+
"""{"test_modified":null}""",
20+
defaultMapper.writeValueAsString(mapOf(Value("test") to null)),
21+
)
22+
}
23+
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
package com.fasterxml.jackson.module.kotlin.kogeraIntegration.ser.valueClass.jsonKey
2+
3+
import com.fasterxml.jackson.annotation.JsonKey
4+
import com.fasterxml.jackson.module.kotlin.defaultMapper
5+
import org.junit.jupiter.api.Assertions.assertEquals
6+
import org.junit.jupiter.api.Test
7+
8+
class NullablePrimitiveTest {
9+
@JvmInline
10+
value class Value(val v: Int?) {
11+
@JsonKey
12+
fun jsonValue() = v?.let { it + 100 }
13+
}
14+
15+
// The case of returning null as a key is unnecessary because it will result in an error
16+
@Test
17+
fun test() {
18+
assertEquals(
19+
"""{"100":null}""",
20+
defaultMapper.writeValueAsString(mapOf(Value(0) to null)),
21+
)
22+
}
23+
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
package com.fasterxml.jackson.module.kotlin.kogeraIntegration.ser.valueClass.jsonKey
2+
3+
import com.fasterxml.jackson.annotation.JsonKey
4+
import com.fasterxml.jackson.module.kotlin.defaultMapper
5+
import org.junit.jupiter.api.Assertions.assertEquals
6+
import org.junit.jupiter.api.Test
7+
8+
class PrimitiveTest {
9+
@JvmInline
10+
value class NonNull(val v: Int) {
11+
@JsonKey
12+
fun jsonValue() = v + 100
13+
}
14+
15+
@Test
16+
fun nonNullTest() {
17+
assertEquals(
18+
"""{"100":null}""",
19+
defaultMapper.writeValueAsString(mapOf(NonNull(0) to null)),
20+
)
21+
}
22+
23+
@JvmInline
24+
value class Nullable(val v: Int) {
25+
@JsonKey
26+
fun jsonValue() = v.takeIf { it % 2 == 0 }?.let { it + 100 }
27+
}
28+
29+
// The case of returning null as a key is unnecessary because it will result in an error
30+
@Test
31+
fun nullableTest() {
32+
assertEquals(
33+
"""{"100":null}""",
34+
defaultMapper.writeValueAsString(mapOf(Nullable(0) to null)),
35+
)
36+
}
37+
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
package com.fasterxml.jackson.module.kotlin.kogeraIntegration.ser.valueClass.jsonKey
2+
3+
import com.fasterxml.jackson.annotation.JsonKey
4+
import com.fasterxml.jackson.module.kotlin.defaultMapper
5+
import org.junit.jupiter.api.Assertions.assertEquals
6+
import org.junit.jupiter.api.Test
7+
8+
class TwoUnitPrimitiveTest {
9+
@JvmInline
10+
value class NonNull(val v: Long) {
11+
@JsonKey
12+
fun jsonValue() = v + 100
13+
}
14+
15+
@Test
16+
fun nonNullTest() {
17+
assertEquals(
18+
"""{"100":null}""",
19+
defaultMapper.writeValueAsString(mapOf(NonNull(0) to null)),
20+
)
21+
}
22+
23+
@JvmInline
24+
value class Nullable(val v: Long) {
25+
@JsonKey
26+
fun jsonValue() = v.takeIf { it % 2L == 0L }?.let { it + 100 }
27+
}
28+
29+
// The case of returning null as a key is unnecessary because it will result in an error
30+
@Test
31+
fun nullableTest() {
32+
assertEquals(
33+
"""{"100":null}""",
34+
defaultMapper.writeValueAsString(mapOf(Nullable(0) to null)),
35+
)
36+
}
37+
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,85 @@
1+
package com.fasterxml.jackson.module.kotlin.kogeraIntegration.ser.valueClass.jsonValue
2+
3+
import com.fasterxml.jackson.annotation.JsonValue
4+
import com.fasterxml.jackson.module.kotlin.defaultMapper
5+
import org.junit.jupiter.api.Assertions.assertEquals
6+
import org.junit.jupiter.api.Nested
7+
import org.junit.jupiter.api.Test
8+
9+
class NonNullObjectTest {
10+
@JvmInline
11+
value class NonNull(val v: String) {
12+
@JsonValue
13+
fun jsonValue() = v + "_modified"
14+
}
15+
16+
data class NonNullDto(val v: NonNull)
17+
18+
@Nested
19+
inner class NonNullTest {
20+
@Test
21+
fun direct() {
22+
assertEquals(
23+
"\"test_modified\"",
24+
defaultMapper.writeValueAsString(NonNull("test")),
25+
)
26+
}
27+
28+
@Test
29+
fun asProperty() {
30+
assertEquals(
31+
"""{"v":"test_modified"}""",
32+
defaultMapper.writeValueAsString(NonNullDto(NonNull("test"))),
33+
)
34+
}
35+
}
36+
37+
@JvmInline
38+
value class Nullable(val v: String) {
39+
@JsonValue
40+
fun jsonValue() = v.takeIf { it.length % 2 == 0 }?.let { it + "_modified" }
41+
}
42+
43+
data class NullableDto(val v: Nullable)
44+
45+
@Nested
46+
inner class NullableTest {
47+
@Nested
48+
inner class DirectTest {
49+
@Test
50+
fun nonNull() {
51+
assertEquals(
52+
"\"even_modified\"",
53+
defaultMapper.writeValueAsString(Nullable("even")),
54+
)
55+
}
56+
57+
@Test
58+
fun `null`() {
59+
assertEquals(
60+
"null",
61+
defaultMapper.writeValueAsString(Nullable("odd")),
62+
)
63+
}
64+
}
65+
66+
@Nested
67+
inner class AsPropertyTest {
68+
@Test
69+
fun nonNull() {
70+
assertEquals(
71+
"""{"v":"even_modified"}""",
72+
defaultMapper.writeValueAsString(NullableDto(Nullable("even"))),
73+
)
74+
}
75+
76+
@Test
77+
fun `null`() {
78+
assertEquals(
79+
"""{"v":null}""",
80+
defaultMapper.writeValueAsString(NullableDto(Nullable("odd"))),
81+
)
82+
}
83+
}
84+
}
85+
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
1+
package com.fasterxml.jackson.module.kotlin.kogeraIntegration.ser.valueClass.jsonValue
2+
3+
import com.fasterxml.jackson.annotation.JsonValue
4+
import com.fasterxml.jackson.module.kotlin.defaultMapper
5+
import org.junit.jupiter.api.Assertions.assertEquals
6+
import org.junit.jupiter.api.Nested
7+
import org.junit.jupiter.api.Test
8+
9+
class NullableObjectTest {
10+
@JvmInline
11+
value class Value(val v: String?) {
12+
@JsonValue
13+
fun jsonValue() = v?.let { it + "_modified" }
14+
}
15+
16+
@Nested
17+
inner class DirectTest {
18+
@Test
19+
fun nonNull() {
20+
assertEquals(
21+
"\"test_modified\"",
22+
defaultMapper.writeValueAsString(Value("test")),
23+
)
24+
}
25+
26+
@Test
27+
fun `null`() {
28+
assertEquals(
29+
"null",
30+
defaultMapper.writeValueAsString(Value(null)),
31+
)
32+
}
33+
}
34+
35+
data class Dto(val v: Value)
36+
37+
@Nested
38+
inner class AsPropertyTest {
39+
@Test
40+
fun nonNull() {
41+
assertEquals(
42+
"""{"v":"test_modified"}""",
43+
defaultMapper.writeValueAsString(Dto(Value("test"))),
44+
)
45+
}
46+
47+
@Test
48+
fun `null`() {
49+
assertEquals(
50+
"""{"v":null}""",
51+
defaultMapper.writeValueAsString(Dto(Value(null))),
52+
)
53+
}
54+
}
55+
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
1+
package com.fasterxml.jackson.module.kotlin.kogeraIntegration.ser.valueClass.jsonValue
2+
3+
import com.fasterxml.jackson.annotation.JsonValue
4+
import com.fasterxml.jackson.module.kotlin.defaultMapper
5+
import org.junit.jupiter.api.Assertions.assertEquals
6+
import org.junit.jupiter.api.Nested
7+
import org.junit.jupiter.api.Test
8+
9+
class NullablePrimitiveTest {
10+
@JvmInline
11+
value class Value(val v: Int?) {
12+
@JsonValue
13+
fun jsonValue() = v?.let { it + 100 }
14+
}
15+
16+
@Nested
17+
inner class DirectTest {
18+
@Test
19+
fun nonNull() {
20+
assertEquals(
21+
"100",
22+
defaultMapper.writeValueAsString(Value(0)),
23+
)
24+
}
25+
26+
@Test
27+
fun `null`() {
28+
assertEquals(
29+
"null",
30+
defaultMapper.writeValueAsString(Value(null)),
31+
)
32+
}
33+
}
34+
35+
data class Dto(val v: Value)
36+
37+
@Nested
38+
inner class AsPropertyTest {
39+
@Test
40+
fun nonNull() {
41+
assertEquals(
42+
"""{"v":100}""",
43+
defaultMapper.writeValueAsString(Dto(Value(0))),
44+
)
45+
}
46+
47+
@Test
48+
fun `null`() {
49+
assertEquals(
50+
"""{"v":null}""",
51+
defaultMapper.writeValueAsString(Dto(Value(null))),
52+
)
53+
}
54+
}
55+
}

0 commit comments

Comments
 (0)