TValueHelper.Equals handles comparing values that contain TValue

Author: sglienke

Source/Base/Spring.pas

@@ -3473,6 +3473,10 @@ function EqualsRec2Rec(const left, right: TValue): Boolean;
   leftRec, rightRec: Pointer;
   leftValue, rightValue: TValue;
 begin
+  if (left.TypeInfo = TypeInfo(TValue)) and (right.TypeInfo = TypeInfo(TValue)) then
+    Exit(PValue(left.GetReferenceToRawData).Equals(
+      PValue(right.GetReferenceToRawData)^));
+
   recordType := left.TypeInfo.RttiType;
   for method in recordType.GetMethods('&op_Equality') do
   begin

Tests/Source/Base/Spring.Tests.Base.pas

@@ -435,6 +435,8 @@   TTestValueHelper = class(TTestCase)
     procedure EqualsReturnsTrueForEqualPointers;
     procedure EqualsReturnsFalseForUnequalPointers;
 
+    procedure EqualsReturnsTrueForEqualTValue;
+
     procedure FromVariantProperlyHandlesVariantArrays;
 
     procedure ConvertStringToIntegerFailsForInvalidString;
@@ -2552,6 +2554,16 @@ procedure TTestValueHelper.EqualsReturnsTrueForEqualPointers;
   DoCheckEquals;
 end;
 
+procedure TTestValueHelper.EqualsReturnsTrueForEqualTValue;
+var
+  nums: TArray<Integer>;
+begin
+  nums := TArray<Integer>.Create(42);
+  fSUT := TValue.From(TValue.From(nums));
+  fValue := TValue.From(TValue.From(nums));
+  DoCheckEquals;
+end;
+
 procedure TTestValueHelper.EqualsReturnsTrueForEqualVariantArrayOfVariantArray;
 var
   v1, v2: Variant;