Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: Take ge/le into consideration when checking the prefix with the prefix-list #17615

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

lib: Take ge/le into consideration when checking the prefix with the prefix-list #17615

wants to merge 1 commit into from

Conversation

ton31337
Copy link
Member

@ton31337 ton31337 commented Dec 10, 2024 •
edited
Loading

Closes #17612

@ton31337
lib: Take ge/le into consideration when checking the prefix with the …
dd4c2ac 
…prefix-list

Without the fix:

```
show ip prefix-list test_1 10.20.30.96/27 first-match
 <no result>

show ip prefix-list test_2 192.168.1.2/32 first-match
 <no result>
```

With the fix:

```
ip prefix-list test_1 seq 10 permit 10.20.30.64/26 le 27
!
end
donatas# show ip prefix-list test_1 10.20.30.96/27
   seq 10 permit 10.20.30.64/26 le 27 (hit count: 1, refcount: 0)
donatas# show ip prefix-list test_1 10.20.30.64/27
   seq 10 permit 10.20.30.64/26 le 27 (hit count: 2, refcount: 0)
donatas# show ip prefix-list test_1 10.20.30.64/28
donatas# show ip prefix-list test_1 10.20.30.126/26
   seq 10 permit 10.20.30.64/26 le 27 (hit count: 3, refcount: 0)
donatas# show ip prefix-list test_1 10.20.30.126/30
donatas#
```

Signed-off-by: Donatas Abraitis <[email protected]>
@frrbot frrbot bot added the libfrr label Dec 10, 2024
@ton31337 ton31337 mentioned this pull request Dec 10, 2024
Open
2 tasks
@riw777 riw777 self-requested a review December 10, 2024 16:27
riw777
riw777 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@ton31337
Copy link
Member Author

@Mergifyio backport stable/10.2 stable/10.1 stable/10.0 stable/9.1 stable/9.0 stable/8.5

@mergify Mergify
Copy link

mergify bot commented Dec 10, 2024

backport stable/10.2 stable/10.1 stable/10.0 stable/9.1 stable/9.0 stable/8.5

🟠 Waiting for conditions to match

  • merged [📌 backport requirement]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riw777 riw777 riw777 approved these changes

Assignees
No one assigned
Labels
backport libfrr master size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

show ip-prefixlist first-match doesn't match le or ge entries
2 participants
@ton31337 @riw777