Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the turret zero position #139

Open
Alenguye582 opened this issue May 11, 2024 · 3 comments
Open

change the turret zero position #139

Alenguye582 opened this issue May 11, 2024 · 3 comments

Comments

@Alenguye582
Copy link
Contributor

make the "max" position the "min" position and vice versa

@ACat701
Copy link
Contributor

ACat701 commented May 12, 2024

Can you clarify what you mean by this? Are you saying that we should make the turret rotation clockwise? It's currently counterclockwise to match the robot coordinate system.

@Alenguye582
Copy link
Contributor Author

Can you clarify what you mean by this? Are you saying that we should make the turret rotation clockwise? It's currently counterclockwise to match the robot coordinate system.

Oh okay. Yeah, I think we wanted to make the rotation clockwise because the starting position of the snake seemed more intuitive if it started at its "max" position currently. I honestly forgot why it seemed more intuitive. (help me @TaylerUva ). But I think we can go with whatever makes sense for future users.

@TaylerUva
Copy link
Member

Can you clarify what you mean by this? Are you saying that we should make the turret rotation clockwise? It's currently counterclockwise to match the robot coordinate system.

Oh okay. Yeah, I think we wanted to make the rotation clockwise because the starting position of the snake seemed more intuitive if it started at its "max" position currently. I honestly forgot why it seemed more intuitive. (help me @TaylerUva ). But I think we can go with whatever makes sense for future users.

I think the rotation direction is was fine. It was the limits that should be reversed. The reason being is the harness on the opposite side than it was in the past. So using the old starting config, to face forward (shoot towards intake) it has to rotate 270 degrees instead of only 90. If we rotate the other way for starting config it solves the problem but the code does not support that. Hope that makes more sense, it will be easier to clarify in person.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants