Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linking steam account goes wrong #549

Open
1-alex98 opened this issue Aug 27, 2024 · 8 comments · May be fixed by #562
Open

Linking steam account goes wrong #549

1-alex98 opened this issue Aug 27, 2024 · 8 comments · May be fixed by #562

Comments

@1-alex98
Copy link
Member Author

However site does show this
image

@1-alex98
Copy link
Member Author

1-alex98 commented Aug 27, 2024

Website should display the error and not act like everything was ok

@1-alex98
Copy link
Member Author

image
I found the message but I think it should be placed more prominently.

@github-staff github-staff deleted a comment from 1-alex98 Aug 27, 2024
@magge-faf
Copy link
Contributor

The Flash-Message change would be very welcome. The additional workload from people who need help resolving the above issue gets tiresome. Usually they already have an account, but do not see the error which reminds them about it.

At first glance, it seems everything went okay, when they come back to the FAF website, even when that was not the case. I wildly assume - not many people scroll down to look for the Flash Box.

The experience could be greatly improved to make the Flash Text far more prominently at top.

@1-alex98
Copy link
Member Author

1-alex98 commented Sep 5, 2024

  • "Should not take more than 1-2 minutes" should not be displayed if there is an error. Kind of makes the user think everything is fine if he waits 2 minutes.
  • Flash message should be displayed at the top. Either displyed twice at the original place and at the top or completely moved to the top. Alternatively site scrolls to the flash message. In any case flash message with the error should be the first thing the user sees.

@Ivan-Shaml
Copy link

What do you think of the interaction bellow:

  1. Users clicks on Link your FAF Account to Steam
  2. Errors out -> the "Should not take more than 1-2 minutes" text is not be displayed
  3. Scrolls to the flash message position and highlights it with another color for 2 seconds
    (same can be done for GOG account linking page)

Video:

newSteamErrorHandling.mp4

@magge-faf
Copy link
Contributor

Thanks for taking a look at this issue. It is a solution to draw users attention to the box.

My concern is, that taking away the control from the user to auto-scroll to a certain point seems kinda "hackish" and unexpected.

Best solution I can think of: the flash-message should be at the top and should be labeled as 'status'. It should get the users' attention by a flashy color, or a neat "shake" effect when something gone wrong. No auto-scroll, just "in your face" at top page.

Any thoughts on the best way to tackle this issue, @Brutus5000?

@Ivan-Shaml
Copy link

Ivan-Shaml commented Jan 3, 2025

(my personal opinion)

Scrolling to an element using anchor link/fragment does basically the same thing, and is pretty common UX practice in many web sites.
Given the fact here the page loads again entirely (its not SPA), we can use the same approach.
Maybe if I change the scroll behavior from smooth to instant it will look better for this use-case.

Video:

2025-01-03.21-35-08.mp4

@Ivan-Shaml Ivan-Shaml linked a pull request Jan 8, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@1-alex98 @Ivan-Shaml @magge-faf and others