Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snap point direction #253

Closed
smygarn opened this issue Jul 9, 2016 · 6 comments
Closed

snap point direction #253

smygarn opened this issue Jul 9, 2016 · 6 comments

Comments

@smygarn
Copy link

smygarn commented Jul 9, 2016

I don't understand the forward direction of snap points. To be able to correct setup a gun in the 014_Controller_SnappingObjectsOnGrab example, you have to point the red (x) angle in about 30 degrees to the right.

@thestonefox
Copy link
Member

It would be better if an explanation of how you think they should work was provided and even better to provide a PR to show your solution.

Hard to deal with an issue based around someone not understanding something.

@smygarn
Copy link
Author

smygarn commented Jul 12, 2016

The best solution is that the snapping point should point in the wanted controlled object space. It should be easy to point out the snapping in the editor. Now you have to make a mathematical transform by yourself, or a lots of trial to make it correct. ;)

The only way to test if you got it right is to pick up the tool in VR.

@thestonefox
Copy link
Member

I looked at this issue last night.

The snap point works as expected when the model is built in the correct orientation (oriented to the controller).

If the model is built in a different orientation then the snap point will look odd as it's rotated in a strange way to meet the orientation of the controller.

I think a gizmo showing the orientation of the controller may help in the future. But in the short, if you add a cube as a child of the controller and model things around the position of the controller then the snap point works as expected.

@smygarn
Copy link
Author

smygarn commented Jul 18, 2016

OK. It's a bit strange though because all my objects needed reorientations when swapping from NewtonVR to VRTK.

@ZackOfAllTrades
Copy link

I hate to beat a dead horse.. I don't get what your driving at. I read this and #472 but I'm not sure the correct way to use VRTK snapping. The object being attached has strange rotations, like a previous commenter said the x value is off about 30 degrees. I modeled a cube as the child of the controller but still same result, maybe I need clarification on what that means. Thanks!!!!

@thestonefox
Copy link
Member

this has been fixed in 3.3.0-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants