SOF-7417: chore ==> rewrite the ternary condition

Author: pranabdas

express/properties/non_scalar/two_dimensional_plot/band_structure.py

@@ -25,7 +25,7 @@ def __init__(self, name, parser, *args, **kwargs):
         # and we return the same for versions above 6.4 if noncolin is True.
         # However, for non-collinear magnetic case there are one eigenvalue per
         # k-pont. Here we override nspins for non-collinear case.
-        self.nspins = self.parser.nspins() if self.parser.nspins() != 4 else 1
+        self.nspins = 1 if self.parser.nspins() == 4 else self.parser.nspins()
 
         self.eigenvalues_at_kpoints = self.parser.eigenvalues_at_kpoints()
         if kwargs.get("remove_non_zero_weight_kpoints", False):