Reset no-unused-vars linting rule to default

Author: Alec Gibson

.eslintrc.js

@@ -24,6 +24,8 @@ const SHAREDB_RULES = {
       ignoreUrls: true,
     }
   ],
+  // Google overrides the default ESLint behaviour here, which is slightly better for catching erroneously unused variables
+  'no-unused-vars': ['error', {vars: 'all', args: 'after-used'}],
   // as-needed quote props are easier to write
   'quote-props': ['error', 'as-needed'],
   'require-jsdoc': 'off',

examples/counter/server.js

@@ -29,7 +29,7 @@ function startServer() {
 
   // Connect any incoming WebSocket connection to ShareDB
   var wss = new WebSocket.Server({server: server});
-  wss.on('connection', function(ws, req) {
+  wss.on('connection', function(ws) {
     var stream = new WebSocketJSONStream(ws);
     backend.listen(stream);
   });

examples/leaderboard/server/index.js

@@ -18,7 +18,7 @@ server.listen(8080);
 console.log('Listening on http://localhost:8080');
 
 // Connect any incoming WebSocket connection with ShareDB
-wss.on('connection', function(ws, req) {
+wss.on('connection', function(ws) {
   var stream = new WebSocketJSONStream(ws);
   share.listen(stream);
 });

examples/rich-text/server.js

@@ -32,7 +32,7 @@ function startServer() {
 
   // Connect any incoming WebSocket connection to ShareDB
   var wss = new WebSocket.Server({server: server});
-  wss.on('connection', function(ws, req) {
+  wss.on('connection', function(ws) {
     var stream = new WebSocketJSONStream(ws);
     backend.listen(stream);
   });

examples/textarea/server.js

@@ -29,7 +29,7 @@ function startServer() {
 
   // Connect any incoming WebSocket connection to ShareDB
   var wss = new WebSocket.Server({server: server});
-  wss.on('connection', function(ws, req) {
+  wss.on('connection', function(ws) {
     var stream = new WebSocketJSONStream(ws);
     backend.listen(stream);
   });

lib/db/memory.js

@@ -122,7 +122,7 @@ MemoryDB.prototype.query = function(collection, query, fields, options, callback
 // two properties:
 // - snapshots: array of query result snapshots
 // - extra: (optional) other types of results, such as counts
-MemoryDB.prototype._querySync = function(snapshots, query, options) {
+MemoryDB.prototype._querySync = function(snapshots) {
   return {snapshots: snapshots};
 };
 

test/client/number-type.js

@@ -18,6 +18,6 @@ function apply(snapshot, op) {
   return snapshot + op;
 }
 
-function transform(op1, op2, side) {
+function transform(op1) {
   return op1;
 }

test/client/query-subscribe.js

@@ -306,7 +306,7 @@ module.exports = function(options) {
         if (err) return done(err);
         connection.get('dogs', 'fido').create({});
       });
-      query.on('insert', function(docs, index) {
+      query.on('insert', function(docs) {
         expect(util.pluck(docs, 'id')).eql(['fido']);
         done();
       });
@@ -320,7 +320,7 @@ module.exports = function(options) {
         if (err) return done(err);
         connection.get('dogs', 'fido').create({});
       });
-      query.on('insert', function(docs, index) {
+      query.on('insert', function(docs) {
         expect(util.pluck(docs, 'id')).eql(['fido']);
         done();
       });

test/client/snapshot-timestamp-request.js

@@ -227,7 +227,8 @@ describe('SnapshotTimestampRequest', function() {
     it('starts pending, and finishes not pending', function(done) {
       var connection = backend.connect();
 
-      connection.fetchSnapshotByTimestamp('books', 'time-machine', null, function(error, snapshot) {
+      connection.fetchSnapshotByTimestamp('books', 'time-machine', null, function(error) {
+        if (error) return done(error);
         expect(connection.hasPending()).to.be(false);
         done();
       });
@@ -357,7 +358,7 @@ describe('SnapshotTimestampRequest', function() {
           }
         ];
 
-        backend.connect().fetchSnapshotByTimestamp('books', 'time-machine', day1, function(error, snapshot) {
+        backend.connect().fetchSnapshotByTimestamp('books', 'time-machine', day1, function(error) {
           expect(error.message).to.be('foo');
           done();
         });

test/client/snapshot-version-request.js

@@ -165,7 +165,8 @@ describe('SnapshotVersionRequest', function() {
     it('starts pending, and finishes not pending', function(done) {
       var connection = backend.connect();
 
-      connection.fetchSnapshot('books', 'don-quixote', null, function(error, snapshot) {
+      connection.fetchSnapshot('books', 'don-quixote', null, function(error) {
+        if (error) return done(error);
         expect(connection.hasPending()).to.be(false);
         done();
       });
@@ -295,7 +296,7 @@ describe('SnapshotVersionRequest', function() {
           }
         ];
 
-        backend.connect().fetchSnapshot('books', 'don-quixote', 0, function(error, snapshot) {
+        backend.connect().fetchSnapshot('books', 'don-quixote', 0, function(error) {
           expect(error.message).to.be('foo');
           done();
         });