-
Notifications
You must be signed in to change notification settings - Fork 447
Expand file tree
/
Copy pathmemory_manager.py
More file actions
1407 lines (1239 loc) · 55.8 KB
/
memory_manager.py
File metadata and controls
1407 lines (1239 loc) · 55.8 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
from __future__ import annotations
from typing import Any, List, Optional, Tuple
import logging
import asyncio
from datetime import datetime, timedelta
import jieba
import numpy as np
import time
from typing import Dict, Any
from dataclasses import dataclass
from api_specs.memory_types import (
BaseMemory,
EpisodeMemory,
EventLog,
Foresight,
RawDataType,
)
from biz_layer.mem_memorize import memorize
from api_specs.dtos import MemorizeRequest
from .fetch_mem_service import get_fetch_memory_service
from api_specs.dtos import (
FetchMemRequest,
FetchMemResponse,
PendingMessage,
RetrieveMemRequest,
RetrieveMemResponse,
)
from api_specs.memory_models import Metadata
from core.di import get_bean_by_type
from core.oxm.constants import MAGIC_ALL
from infra_layer.adapters.out.search.repository.episodic_memory_es_repository import (
EpisodicMemoryEsRepository,
)
from infra_layer.adapters.out.search.repository.foresight_es_repository import (
ForesightEsRepository,
)
from infra_layer.adapters.out.search.repository.event_log_es_repository import (
EventLogEsRepository,
)
from core.observation.tracing.decorators import trace_logger
from core.nlp.stopwords_utils import filter_stopwords
from common_utils.datetime_utils import (
from_iso_format,
get_now_with_timezone,
to_iso_format,
)
from infra_layer.adapters.out.persistence.repository.memcell_raw_repository import (
MemCellRawRepository,
)
from service.memory_request_log_service import MemoryRequestLogService
from infra_layer.adapters.out.persistence.repository.group_user_profile_memory_raw_repository import (
GroupUserProfileMemoryRawRepository,
)
from infra_layer.adapters.out.persistence.document.memory.memcell import DataTypeEnum
from infra_layer.adapters.out.persistence.document.memory.user_profile import (
UserProfile,
)
from infra_layer.adapters.out.search.repository.episodic_memory_milvus_repository import (
EpisodicMemoryMilvusRepository,
)
from infra_layer.adapters.out.search.repository.foresight_milvus_repository import (
ForesightMilvusRepository,
)
from infra_layer.adapters.out.search.repository.event_log_milvus_repository import (
EventLogMilvusRepository,
)
from .vectorize_service import get_vectorize_service
from .rerank_service import get_rerank_service
from api_specs.memory_models import MemoryType, RetrieveMethod
from agentic_layer.metrics.retrieve_metrics import (
record_retrieve_request,
record_retrieve_stage,
record_retrieve_error,
)
import os
from memory_layer.llm.llm_provider import LLMProvider
from agentic_layer.agentic_utils import (
AgenticConfig,
check_sufficiency,
generate_multi_queries,
)
from agentic_layer.retrieval_utils import reciprocal_rank_fusion
logger = logging.getLogger(__name__)
# MemoryType -> ES Repository mapping
ES_REPO_MAP = {
MemoryType.FORESIGHT: ForesightEsRepository,
MemoryType.EVENT_LOG: EventLogEsRepository,
MemoryType.EPISODIC_MEMORY: EpisodicMemoryEsRepository,
}
# Milvus repository mapping - same types as ES but for vector search
MILVUS_REPO_MAP = {
MemoryType.FORESIGHT: ForesightMilvusRepository,
MemoryType.EVENT_LOG: EventLogMilvusRepository,
MemoryType.EPISODIC_MEMORY: EpisodicMemoryMilvusRepository,
}
@dataclass
class EventLogCandidate:
"""Event Log candidate object (used for retrieval from atomic_fact)"""
event_id: str
user_id: str
group_id: str
timestamp: datetime
episode: str # atomic_fact content
summary: str
subject: str
extend: dict # contains embedding
class MemoryManager:
"""Unified memory interface.
Provides the following main functions:
- memorize: Accept raw data and persistently store
- fetch_mem: Retrieve memory fields by key, supports multiple memory types
- retrieve_mem: Memory reading based on prompt-based retrieval methods
"""
def __init__(self) -> None:
# Get memory service instance
self._fetch_service = get_fetch_memory_service()
self._request_log_service: MemoryRequestLogService = get_bean_by_type(
MemoryRequestLogService
)
logger.info(
"MemoryManager initialized with fetch_mem_service and retrieve_mem_service"
)
# --------- Write path (raw data -> memorize) ---------
@trace_logger(operation_name="agentic_layer memory storage")
async def memorize(self, memorize_request: MemorizeRequest) -> int:
"""Memorize a heterogeneous list of raw items.
Accepts list[Any], where each item can be one of the typed raw dataclasses
(ChatRawData / EmailRawData / MemoRawData / LincDocRawData) or any dict-like
object. Each item is stored as a MemoryCell with a synthetic key.
Returns:
int: Number of memories extracted (0 if no boundary detected)
"""
count = await memorize(memorize_request)
return count
# --------- Read path (query -> fetch_mem) ---------
# Memory reading based on key-value, including static and dynamic memory
@trace_logger(operation_name="agentic_layer memory reading")
async def fetch_mem(self, request: FetchMemRequest) -> FetchMemResponse:
"""Retrieve memory data, supports multiple memory types
Args:
request: FetchMemRequest containing query parameters
Returns:
FetchMemResponse containing query results
"""
logger.debug(
f"fetch_mem called with request: user_id={request.user_id}, group_id={request.group_id}, "
f"memory_type={request.memory_type}, time_range=[{request.start_time}, {request.end_time}]"
)
# repository supports MemoryType.EPISODIC_MEMORY type, default is episodic memory
response = await self._fetch_service.find_memories(
user_id=request.user_id,
memory_type=request.memory_type,
group_id=request.group_id,
start_time=request.start_time,
end_time=request.end_time,
version_range=request.version_range,
limit=request.limit,
)
# Note: response.metadata already contains complete employee information
# including source, user_id, memory_type, limit, email, phone, full_name
# No need to update again here, as fetch_mem_service already provides correct information
logger.debug(
f"fetch_mem returned {len(response.memories)} memories for user {request.user_id}"
)
return response
# Memory reading based on retrieve_method, including static and dynamic memory
@trace_logger(operation_name="agentic_layer memory retrieval")
async def retrieve_mem(
self, retrieve_mem_request: 'RetrieveMemRequest'
) -> RetrieveMemResponse:
"""Retrieve memory data, dispatching to different retrieval methods based on retrieve_method
Args:
retrieve_mem_request: RetrieveMemRequest containing retrieval parameters
Returns:
RetrieveMemResponse containing retrieval results
"""
try:
# Validate request parameters
if not retrieve_mem_request:
raise ValueError("retrieve_mem_request is required for retrieve_mem")
# Dispatch based on retrieve_method
retrieve_method = retrieve_mem_request.retrieve_method
logger.info(
f"retrieve_mem dispatching request: user_id={retrieve_mem_request.user_id}, "
f"retrieve_method={retrieve_method}, query={retrieve_mem_request.query}"
)
# Create task to fetch pending messages concurrently
pending_messages_task = asyncio.create_task(
self._get_pending_messages(
user_id=retrieve_mem_request.user_id,
group_id=retrieve_mem_request.group_id,
)
)
# Dispatch based on retrieval method
match retrieve_method:
case RetrieveMethod.KEYWORD:
response = await self.retrieve_mem_keyword(retrieve_mem_request)
case RetrieveMethod.VECTOR:
response = await self.retrieve_mem_vector(retrieve_mem_request)
case RetrieveMethod.HYBRID:
response = await self.retrieve_mem_hybrid(retrieve_mem_request)
case RetrieveMethod.RRF:
response = await self.retrieve_mem_rrf(retrieve_mem_request)
case RetrieveMethod.AGENTIC:
response = await self.retrieve_mem_agentic(retrieve_mem_request)
case _:
raise ValueError(f"Unsupported retrieval method: {retrieve_method}")
# Await pending messages and attach to response
pending_messages = await pending_messages_task
response.pending_messages = pending_messages
return response
except Exception as e:
logger.error(f"Error in retrieve_mem: {e}", exc_info=True)
return RetrieveMemResponse(
memories=[],
original_data=[],
scores=[],
importance_scores=[],
total_count=0,
has_more=False,
query_metadata=Metadata(
source="retrieve_mem_service",
user_id=(
retrieve_mem_request.user_id if retrieve_mem_request else ""
),
memory_type="retrieve",
),
metadata=Metadata(
source="retrieve_mem_service",
user_id=(
retrieve_mem_request.user_id if retrieve_mem_request else ""
),
memory_type="retrieve",
),
pending_messages=[],
)
async def _get_pending_messages(
self, user_id: Optional[str] = None, group_id: Optional[str] = None
) -> List[PendingMessage]:
"""
Get pending (unconsumed) messages from MemoryRequestLogService.
Fetches cached memory data that hasn't been consumed yet (sync_status=-1 or 0).
Args:
user_id: User ID filter (from retrieve_request)
group_id: Group ID filter (from retrieve_request)
Returns:
List of PendingMessage objects
"""
try:
result = await self._request_log_service.get_pending_messages(
user_id=user_id, group_id=group_id, limit=1000
)
logger.debug(
f"Retrieved {len(result)} pending messages: "
f"user_id={user_id}, group_id={group_id}"
)
return result
except Exception as e:
logger.error(f"Error fetching pending messages: {e}", exc_info=True)
return []
# Keyword retrieval method (original retrieve_mem logic)
@trace_logger(operation_name="agentic_layer keyword memory retrieval")
async def retrieve_mem_keyword(
self, retrieve_mem_request: 'RetrieveMemRequest'
) -> RetrieveMemResponse:
"""Keyword-based memory retrieval"""
start_time = time.perf_counter()
memory_type = (
retrieve_mem_request.memory_types[0].value
if retrieve_mem_request.memory_types
else 'unknown'
)
try:
hits = await self.get_keyword_search_results(
retrieve_mem_request, retrieve_method=RetrieveMethod.KEYWORD.value
)
duration = time.perf_counter() - start_time
status = 'success' if hits else 'empty_result'
record_retrieve_request(
memory_type=memory_type,
retrieve_method=RetrieveMethod.KEYWORD.value,
status=status,
duration_seconds=duration,
results_count=len(hits),
)
return await self._to_response(hits, retrieve_mem_request)
except Exception as e:
duration = time.perf_counter() - start_time
record_retrieve_request(
memory_type=memory_type,
retrieve_method=RetrieveMethod.KEYWORD.value,
status='error',
duration_seconds=duration,
results_count=0,
)
logger.error(f"Error in retrieve_mem_keyword: {e}", exc_info=True)
return await self._to_response([], retrieve_mem_request)
async def get_keyword_search_results(
self,
retrieve_mem_request: 'RetrieveMemRequest',
retrieve_method: str = RetrieveMethod.KEYWORD.value,
) -> List[Dict[str, Any]]:
"""Keyword search with stage-level metrics - searches all supported memory types"""
stage_start = time.perf_counter()
# Get all memory types for metrics recording (use first one as representative)
memory_type = (
retrieve_mem_request.memory_types[0].value
if retrieve_mem_request.memory_types
else 'unknown'
)
try:
# Get parameters from Request
if not retrieve_mem_request:
raise ValueError("retrieve_mem_request is required for retrieve_mem")
top_k = retrieve_mem_request.top_k
query = retrieve_mem_request.query
user_id = retrieve_mem_request.user_id
group_id = retrieve_mem_request.group_id
start_time = retrieve_mem_request.start_time
end_time = retrieve_mem_request.end_time
memory_types = retrieve_mem_request.memory_types
# Convert query string to search word list
# Use jieba for search mode word segmentation, then filter stopwords
if query:
raw_words = list(jieba.cut_for_search(query))
query_words = filter_stopwords(raw_words, min_length=2)
else:
query_words = []
logger.debug(f"query_words: {query_words}")
# Build time range filter conditions, handle None values
date_range = {}
if start_time is not None:
date_range["gte"] = start_time
if end_time is not None:
date_range["lte"] = end_time
# Filter to only supported memory types (exclude profile, etc. that aren't in ES)
supported_types = [mt for mt in memory_types if mt in ES_REPO_MAP]
if not supported_types:
logger.warning(f"No supported memory_types for keyword search. Requested: {[mt.value for mt in memory_types]}")
return []
# Search each supported memory type and collect all results
all_results = []
for mem_type in supported_types:
repo_class = ES_REPO_MAP.get(mem_type)
if not repo_class:
logger.info(f"Skipping unsupported memory_type in keyword search: {mem_type}")
continue
es_repo = get_bean_by_type(repo_class)
logger.debug(f"Using {repo_class.__name__} for {mem_type}")
try:
results = await es_repo.multi_search(
query=query_words,
user_id=user_id,
group_id=group_id,
size=top_k,
from_=0,
date_range=date_range,
)
# Mark memory_type, search_source, and unified score
if results:
for r in results:
r['memory_type'] = mem_type.value
r['_search_source'] = RetrieveMethod.KEYWORD.value
r['id'] = r.get('_id', '') # Unify ES '_id' to 'id'
r['score'] = r.get('_score', 0.0) # Unified score field
all_results.extend(results)
except Exception as e:
logger.warning(f"Keyword search failed for {mem_type}: {e}")
continue
# Record stage metrics
record_retrieve_stage(
retrieve_method=retrieve_method,
stage=RetrieveMethod.KEYWORD.value,
memory_type=memory_type,
duration_seconds=time.perf_counter() - stage_start,
)
return all_results
except Exception as e:
record_retrieve_stage(
retrieve_method=retrieve_method,
stage=RetrieveMethod.KEYWORD.value,
memory_type=memory_type,
duration_seconds=time.perf_counter() - stage_start,
)
record_retrieve_error(
retrieve_method=retrieve_method,
stage=RetrieveMethod.KEYWORD.value,
error_type=self._classify_retrieve_error(e),
)
logger.error(f"Error in get_keyword_search_results: {e}")
raise
# Vector-based memory retrieval
@trace_logger(operation_name="agentic_layer vector memory retrieval")
async def retrieve_mem_vector(
self, retrieve_mem_request: 'RetrieveMemRequest'
) -> RetrieveMemResponse:
"""Vector-based memory retrieval"""
start_time = time.perf_counter()
memory_type = (
retrieve_mem_request.memory_types[0].value
if retrieve_mem_request.memory_types
else 'unknown'
)
try:
hits = await self.get_vector_search_results(
retrieve_mem_request, retrieve_method=RetrieveMethod.VECTOR.value
)
duration = time.perf_counter() - start_time
status = 'success' if hits else 'empty_result'
record_retrieve_request(
memory_type=memory_type,
retrieve_method=RetrieveMethod.VECTOR.value,
status=status,
duration_seconds=duration,
results_count=len(hits),
)
return await self._to_response(hits, retrieve_mem_request)
except Exception as e:
duration = time.perf_counter() - start_time
record_retrieve_request(
memory_type=memory_type,
retrieve_method=RetrieveMethod.VECTOR.value,
status='error',
duration_seconds=duration,
results_count=0,
)
logger.error(f"Error in retrieve_mem_vector: {e}")
return await self._to_response([], retrieve_mem_request)
async def get_vector_search_results(
self,
retrieve_mem_request: 'RetrieveMemRequest',
retrieve_method: str = RetrieveMethod.VECTOR.value,
) -> List[Dict[str, Any]]:
"""Vector search with stage-level metrics - searches all supported memory types"""
memory_type = (
retrieve_mem_request.memory_types[0].value
if retrieve_mem_request.memory_types
else 'unknown'
)
try:
# Get parameters from Request
logger.debug(
f"get_vector_search_results called with retrieve_mem_request: {retrieve_mem_request}"
)
if not retrieve_mem_request:
raise ValueError(
"retrieve_mem_request is required for get_vector_search_results"
)
query = retrieve_mem_request.query
if not query:
raise ValueError("query is required for retrieve_mem_vector")
user_id = retrieve_mem_request.user_id
group_id = retrieve_mem_request.group_id
top_k = retrieve_mem_request.top_k
start_time = retrieve_mem_request.start_time
end_time = retrieve_mem_request.end_time
memory_types = retrieve_mem_request.memory_types
logger.debug(
f"retrieve_mem_vector called with query: {query}, user_id: {user_id}, group_id: {group_id}, top_k: {top_k}"
)
# Get vectorization service
vectorize_service = get_vectorize_service()
# Convert query text to vector (embedding stage)
logger.debug(f"Starting to vectorize query text: {query}")
embedding_start = time.perf_counter()
query_vector = await vectorize_service.get_embedding(query)
query_vector_list = query_vector.tolist() # Convert to list format
record_retrieve_stage(
retrieve_method=retrieve_method,
stage='embedding',
memory_type=memory_type,
duration_seconds=time.perf_counter() - embedding_start,
)
logger.debug(
f"Query text vectorization completed, vector dimension: {len(query_vector_list)}"
)
# Filter to only supported memory types (exclude profile, etc. that aren't in Milvus)
supported_types = [mt for mt in memory_types if mt in MILVUS_REPO_MAP]
if not supported_types:
logger.warning(f"No supported memory_types for vector search. Requested: {[mt.value for mt in memory_types]}")
return []
# Search each supported memory type and collect all results
all_results = []
for mem_type in supported_types:
# Select Milvus repository based on memory type
milvus_repo_class = MILVUS_REPO_MAP.get(mem_type)
if not milvus_repo_class:
logger.info(f"Skipping unsupported memory_type in vector search: {mem_type}")
continue
milvus_repo = get_bean_by_type(milvus_repo_class)
# Handle time range filter conditions
start_time_dt = None
end_time_dt = None
current_time_dt = None
if start_time is not None:
start_time_dt = (
from_iso_format(start_time)
if isinstance(start_time, str)
else start_time
)
if end_time is not None:
if isinstance(end_time, str):
end_time_dt = from_iso_format(end_time)
# If date only format, set to end of day
if len(end_time) == 10:
end_time_dt = end_time_dt.replace(hour=23, minute=59, second=59)
else:
end_time_dt = end_time
# Handle foresight time range (only valid for foresight)
if mem_type == MemoryType.FORESIGHT:
if retrieve_mem_request.start_time:
start_time_dt = from_iso_format(retrieve_mem_request.start_time)
if retrieve_mem_request.end_time:
end_time_dt = from_iso_format(retrieve_mem_request.end_time)
if retrieve_mem_request.current_time:
current_time_dt = from_iso_format(retrieve_mem_request.current_time)
# Call Milvus vector search (pass different parameters based on memory type)
milvus_start = time.perf_counter()
try:
if mem_type == MemoryType.FORESIGHT:
# Foresight: supports time range and validity filtering, supports radius parameter
search_results = await milvus_repo.vector_search(
query_vector=query_vector_list,
user_id=user_id,
group_id=group_id,
start_time=start_time_dt,
end_time=end_time_dt,
current_time=current_time_dt,
limit=top_k,
score_threshold=0.0,
radius=retrieve_mem_request.radius,
)
else:
# Episodic memory and event log: use timestamp filtering, supports radius parameter
search_results = await milvus_repo.vector_search(
query_vector=query_vector_list,
user_id=user_id,
group_id=group_id,
start_time=start_time_dt,
end_time=end_time_dt,
limit=top_k,
score_threshold=0.0,
radius=retrieve_mem_request.radius,
)
# Mark memory_type and search_source
if search_results:
for r in search_results:
r['memory_type'] = mem_type.value
r['_search_source'] = RetrieveMethod.VECTOR.value
all_results.extend(search_results)
except Exception as e:
logger.warning(f"Vector search failed for {mem_type}: {e}")
continue
record_retrieve_stage(
retrieve_method=retrieve_method,
stage='milvus_search',
memory_type=memory_type,
duration_seconds=time.perf_counter() - milvus_start,
)
return all_results
except Exception as e:
record_retrieve_stage(
retrieve_method=retrieve_method,
stage=RetrieveMethod.VECTOR.value,
memory_type=memory_type,
duration_seconds=time.perf_counter() - milvus_start,
)
record_retrieve_error(
retrieve_method=retrieve_method,
stage=RetrieveMethod.VECTOR.value,
error_type=self._classify_retrieve_error(e),
)
logger.error(f"Error in get_vector_search_results: {e}")
raise
# Hybrid memory retrieval
@trace_logger(operation_name="agentic_layer hybrid memory retrieval")
async def retrieve_mem_hybrid(
self, retrieve_mem_request: 'RetrieveMemRequest'
) -> RetrieveMemResponse:
"""Hybrid memory retrieval: keyword + vector + rerank"""
start_time = time.perf_counter()
memory_type = (
retrieve_mem_request.memory_types[0].value
if retrieve_mem_request.memory_types
else 'unknown'
)
try:
hits = await self._search_hybrid(
retrieve_mem_request, retrieve_method=RetrieveMethod.HYBRID.value
)
duration = time.perf_counter() - start_time
status = 'success' if hits else 'empty_result'
record_retrieve_request(
memory_type=memory_type,
retrieve_method=RetrieveMethod.HYBRID.value,
status=status,
duration_seconds=duration,
results_count=len(hits),
)
return await self._to_response(hits, retrieve_mem_request)
except Exception as e:
duration = time.perf_counter() - start_time
record_retrieve_request(
memory_type=memory_type,
retrieve_method=RetrieveMethod.HYBRID.value,
status='error',
duration_seconds=duration,
results_count=0,
)
logger.error(f"Error in retrieve_mem_hybrid: {e}")
return await self._to_response([], retrieve_mem_request)
# ================== Core Internal Methods ==================
async def _rerank(
self,
query: str,
hits: List[Dict],
top_k: int,
memory_type: str = 'unknown',
retrieve_method: str = RetrieveMethod.HYBRID.value,
instruction: str = None,
) -> List[Dict]:
"""Rerank hits using rerank service with stage metrics"""
if not hits:
return []
stage_start = time.perf_counter()
try:
result = await get_rerank_service().rerank_memories(
query, hits, top_k, instruction=instruction
)
record_retrieve_stage(
retrieve_method=retrieve_method,
stage='rerank',
memory_type=memory_type,
duration_seconds=time.perf_counter() - stage_start,
)
return result
except Exception as e:
record_retrieve_error(
retrieve_method=retrieve_method,
stage='rerank',
error_type=self._classify_retrieve_error(e),
)
raise
async def _search_hybrid(
self,
request: 'RetrieveMemRequest',
retrieve_method: str = RetrieveMethod.HYBRID.value,
) -> List[Dict]:
"""Core hybrid search: keyword + vector + rerank, returns flat list"""
memory_type = (
request.memory_types[0].value if request.memory_types else 'unknown'
)
# Run keyword and vector search concurrently
kw_results, vec_results = await asyncio.gather(
self.get_keyword_search_results(request, retrieve_method=retrieve_method),
self.get_vector_search_results(request, retrieve_method=retrieve_method),
)
# Deduplicate by id
seen_ids = {h.get('id') for h in kw_results}
merged_results = kw_results + [
h for h in vec_results if h.get('id') not in seen_ids
]
return await self._rerank(
request.query, merged_results, request.top_k, memory_type, retrieve_method
)
async def _search_rrf(
self,
request: 'RetrieveMemRequest',
retrieve_method: str = RetrieveMethod.RRF.value,
) -> List[Dict]:
"""Core RRF search: keyword + vector + RRF fusion, returns flat list"""
memory_type = (
request.memory_types[0].value if request.memory_types else 'unknown'
)
# Run keyword and vector search concurrently
kw, vec = await asyncio.gather(
self.get_keyword_search_results(request, retrieve_method=retrieve_method),
self.get_vector_search_results(request, retrieve_method=retrieve_method),
)
# RRF fusion with stage metrics
rrf_start = time.perf_counter()
kw_tuples = [(h, h.get('score', 0)) for h in kw]
vec_tuples = [(h, h.get('score', 0)) for h in vec]
fused = reciprocal_rank_fusion(kw_tuples, vec_tuples, k=60)
record_retrieve_stage(
retrieve_method=retrieve_method,
stage='rrf_fusion',
memory_type=memory_type,
duration_seconds=time.perf_counter() - rrf_start,
)
return [dict(doc, score=score) for doc, score in fused[: request.top_k]]
def _classify_retrieve_error(self, error: Exception) -> str:
"""Classify error type for metrics"""
error_str = str(error).lower()
if 'timeout' in error_str or 'timed out' in error_str:
return 'timeout'
elif 'connection' in error_str or 'connect' in error_str:
return 'connection_error'
elif 'not found' in error_str or 'notfound' in error_str:
return 'not_found'
elif 'validation' in error_str or 'invalid' in error_str:
return 'validation_error'
else:
return 'unknown'
async def _to_response(
self, hits: List[Dict], req: 'RetrieveMemRequest'
) -> RetrieveMemResponse:
"""Convert flat hits list to grouped RetrieveMemResponse"""
user_id = req.user_id if req else ""
source_type = req.retrieve_method.value
memory_type = req.memory_types[0].value
if not hits:
return RetrieveMemResponse(
memories=[],
original_data=[],
scores=[],
importance_scores=[],
total_count=0,
has_more=False,
query_metadata=Metadata(
source=source_type, user_id=user_id or "", memory_type=memory_type
),
metadata=Metadata(
source=source_type, user_id=user_id or "", memory_type=memory_type
),
)
memories, scores, importance_scores, original_data, total_count = (
await self.group_by_groupid_stratagy(hits, source_type=source_type)
)
return RetrieveMemResponse(
memories=memories,
scores=scores,
importance_scores=importance_scores,
original_data=original_data,
total_count=total_count,
has_more=False,
query_metadata=Metadata(
source=source_type, user_id=user_id or "", memory_type=memory_type
),
metadata=Metadata(
source=source_type, user_id=user_id or "", memory_type=memory_type
),
)
# --------- RRF retrieval (keyword + vector + RRF fusion, no rerank) ---------
@trace_logger(operation_name="agentic_layer RRF memory retrieval")
async def retrieve_mem_rrf(
self, retrieve_mem_request: 'RetrieveMemRequest'
) -> RetrieveMemResponse:
"""RRF-based memory retrieval: keyword + vector + RRF fusion"""
start_time = time.perf_counter()
memory_type = (
retrieve_mem_request.memory_types[0].value
if retrieve_mem_request.memory_types
else 'unknown'
)
try:
hits = await self._search_rrf(
retrieve_mem_request, retrieve_method=RetrieveMethod.RRF.value
)
duration = time.perf_counter() - start_time
status = 'success' if hits else 'empty_result'
record_retrieve_request(
memory_type=memory_type,
retrieve_method=RetrieveMethod.RRF.value,
status=status,
duration_seconds=duration,
results_count=len(hits),
)
return await self._to_response(hits, retrieve_mem_request)
except Exception as e:
duration = time.perf_counter() - start_time
record_retrieve_request(
memory_type=memory_type,
retrieve_method=RetrieveMethod.RRF.value,
status='error',
duration_seconds=duration,
results_count=0,
)
logger.error(f"Error in retrieve_mem_rrf: {e}", exc_info=True)
return await self._to_response([], retrieve_mem_request)
# --------- Agentic retrieval (LLM-guided multi-round) ---------
@trace_logger(operation_name="agentic_layer Agentic memory retrieval")
async def retrieve_mem_agentic(
self, retrieve_mem_request: 'RetrieveMemRequest'
) -> RetrieveMemResponse:
"""Agentic retrieval: LLM-guided multi-round intelligent retrieval
Process: Round 1 (Hybrid) → Rerank → LLM sufficiency check → Round 2 (multi-query) → Merge → Final Rerank
"""
start_time = time.perf_counter()
req = retrieve_mem_request # alias
top_k = req.top_k
config = AgenticConfig()
memory_type = req.memory_types[0].value if req.memory_types else 'unknown'
try:
llm_provider = LLMProvider(
provider_type=os.getenv("LLM_PROVIDER", "openai"),
model=os.getenv("LLM_MODEL", "Qwen3-235B"),
base_url=os.getenv("LLM_BASE_URL"),
api_key=os.getenv("LLM_API_KEY"),
temperature=float(os.getenv("LLM_TEMPERATURE", "0.3")),
max_tokens=int(os.getenv("LLM_MAX_TOKENS", "16384")),
)
logger.info(f"Agentic Retrieval: {req.query[:60]}...")
# ========== Round 1: Hybrid search ==========
req1 = RetrieveMemRequest(
query=req.query,
user_id=req.user_id,
group_id=req.group_id,
top_k=config.round1_top_n,
memory_types=req.memory_types,
)
round1 = await self._search_hybrid(req1, retrieve_method='agentic')
logger.info(f"Round 1: {len(round1)} memories")
if not round1:
duration = time.perf_counter() - start_time
record_retrieve_request(
memory_type=memory_type,
retrieve_method=RetrieveMethod.AGENTIC.value,
status='empty_result',
duration_seconds=duration,
results_count=0,
)
return await self._to_response([], req)
# ========== Rerank → max(5, top_k) for LLM & return ==========
rerank_n = max(config.round1_rerank_top_n, top_k)
reranked = await self._rerank(
req.query, round1, rerank_n, memory_type, 'agentic',
instruction=config.reranker_instruction,
)
# Use top 5 for sufficiency check
topn_for_llm = reranked[:config.round1_rerank_top_n]
topn_pairs = [(m, m.get("score", 0)) for m in topn_for_llm]
# ========== LLM sufficiency check ==========
is_sufficient, reasoning, missing_info = await check_sufficiency(
query=req.query,
results=topn_pairs,
llm_provider=llm_provider,
max_docs=config.round1_rerank_top_n,
)
logger.info(
f"LLM: {'Sufficient' if is_sufficient else 'Insufficient'} - {reasoning}"
)
if is_sufficient:
# Return reranked results (already done above, no extra rerank)
final_results = reranked[:top_k]
duration = time.perf_counter() - start_time
record_retrieve_request(
memory_type=memory_type,
retrieve_method=RetrieveMethod.AGENTIC.value,
status='success',
duration_seconds=duration,
results_count=len(final_results),
)
return await self._to_response(final_results, req)
# ========== Round 2: Multi-query ==========
refined_queries, _ = await generate_multi_queries(
original_query=req.query,
results=topn_pairs,
missing_info=missing_info,
llm_provider=llm_provider,
max_docs=config.round1_rerank_top_n,
num_queries=config.num_queries,
)
logger.info(f"Generated {len(refined_queries)} queries")
# Parallel hybrid search
async def do_search(q: str) -> List[Dict]:
return await self._search_hybrid(
RetrieveMemRequest(
query=q,
user_id=req.user_id,
group_id=req.group_id,
top_k=config.round2_per_query_top_n,
memory_types=req.memory_types,
),
retrieve_method='agentic',
)
round2_results = await asyncio.gather(
*[do_search(q) for q in refined_queries], return_exceptions=True
)
all_round2 = [
h for r in round2_results if not isinstance(r, Exception) for h in r
]
# Deduplicate and merge
seen_ids = {m.get("id") for m in round1}
round2_unique = [m for m in all_round2 if m.get("id") not in seen_ids]
combined = round1 + round2_unique[: config.combined_total - len(round1)]
logger.info(f"Combined: {len(combined)} memories")