Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stake table contract tests: verify correct events emitted #2658

Open
sveitser opened this issue Feb 21, 2025 · 0 comments
Open

Stake table contract tests: verify correct events emitted #2658

sveitser opened this issue Feb 21, 2025 · 0 comments

Comments

@sveitser
Copy link
Collaborator

sveitser commented Feb 21, 2025

@alysiahuggins I think many of the tests in this PR currently only assert how the contract state changes. That is fine, but what is IMO more important and less of an implementation detail is if the events with correct epochs are emitted because this is what the application will actually consume (not the state of the contract). I think we should add some asserts to check that the epochs in the emitted events evolve as expected.

Originally posted by @sveitser in #2510 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant