Skip to content
This repository was archived by the owner on Feb 27, 2025. It is now read-only.

[TESTING] - Fix Catchup Tests #3673

Open
lukeiannucci opened this issue Sep 12, 2024 · 0 comments
Open

[TESTING] - Fix Catchup Tests #3673

lukeiannucci opened this issue Sep 12, 2024 · 0 comments

Comments

@lukeiannucci
Copy link
Contributor

What is this task and why do we need to work on it?

For test_catchup a node is getting a delayed start. Sometimes the node isnt ready by the time it becomes the leader causing the view to fail and the test to be flaky. To prevent this we currently increase round_start_delay. This isn't the correct solution, this simulates what we are trying to do with the below logic.

What work will need to be done to complete this task?

Add logic to allow the node to get all messages and ignore the previous views. When the node hits the correct view it is set to come up on insert view change and let the node get all the events from the stream.

Are there any other details to include?

No response

What are the acceptance criteria to close this issue?

We can turn down the round_start_delay in the TimingData for test_catchup and the test will not be flaky anymore.

Branch work will be merged to (if not the default branch)

No response

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant