This repository was archived by the owner on Feb 27, 2025. It is now read-only.
fix: Transaction task use quorum exchange instead of committee exchange #1864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n fix all the build breaks
ggutoski
commented
Oct 5, 2023
5 tasks
shenkeyao
previously approved these changes
Oct 5, 2023
crates/types/src/traits/election.rs
Outdated
Comment on lines
623
to
624
| // TODO GG why create a VoteData::DA only to discard it immediately? | ||
| // Why not just have a `sign_commitment()` member? |
There was a problem hiding this comment.
Because we want to distinguish the vote type when signing, so a signature on a no vote can't be used to verify a yes vote.
There was a problem hiding this comment.
But get_commit() just returns the underlying commitment regardless of the enum variant:
HotShot/crates/types/src/traits/election.rs
Lines 103 to 111 in 42d19ba
Hmm. Seems it was me who made that change in #1777: https://github.com/EspressoSystems/HotShot/pull/1777/files
Ok, I need to fix this. I'll push more commits to this PR. Thanks for explaining!
shenkeyao
approved these changes
Oct 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1693
Change the transactions task to use
quorum_exchangeinstead ofcommittee_exchangeso that VID can retrieve the number of storage nodes.The VID erasure code rate is still hard-coded. That's a separate issue #1734 .
Other things in this PR beyond #1693
Committableimpl forVIDBlockPayloadto re-use the commitment bytes instead of computing another commitment of the commitment.test_memory_networkto justfile.TODO GG.