Skip to content
This repository was archived by the owner on Feb 27, 2025. It is now read-only.

Proper source for VID number of storage nodes #1693

Open
ggutoski opened this issue Sep 8, 2023 · 0 comments · Fixed by #1864
Open

Proper source for VID number of storage nodes #1693

ggutoski opened this issue Sep 8, 2023 · 0 comments · Fixed by #1864
Assignees
Labels

Comments

@ggutoski
Copy link
Contributor

ggutoski commented Sep 8, 2023

Currently we hard-code 10 VID storage nodes. Instead, storage nodes should = consensus quorum.

Related but not strictly necessary for this task: #1734

@ggutoski ggutoski self-assigned this Sep 8, 2023
ggutoski added a commit that referenced this issue Sep 8, 2023
@ggutoski ggutoski changed the title Proper source for VID number of storage nodes, data chunks T3.1: Proper source for VID number of storage nodes, data chunks Sep 13, 2023
@ggutoski ggutoski changed the title T3.1: Proper source for VID number of storage nodes, data chunks T3.1: Proper source for VID number of storage nodes Sep 13, 2023
@ggutoski ggutoski changed the title T3.1: Proper source for VID number of storage nodes T5: Proper source for VID number of storage nodes Sep 13, 2023
@ggutoski ggutoski changed the title T5: Proper source for VID number of storage nodes T4.1: Proper source for VID number of storage nodes Sep 13, 2023
ggutoski added a commit that referenced this issue Sep 13, 2023
* quick and dirty type wrappers for VID

* WIP: get dispersal shares

* WIP: add disperse data to VidDisperseSend event

* catch VidDisperseSend event in network task handle_event, plus attendant boilerplate

* WIP catch VidDisperseRecv event in DA task handle_event, plus attendant boilerplate

* new VidVoteSend event

* new event VidVoteRecv

* blind copy-paste code from DAVoteRecv to VidVoteRecv

* new event VidCertSend

* new message type VidCertificate

* new ProcessedCommitteeConsensusMessage variants VidVote, VidCertificate

* new event VidCertRecv

* fix test_da_task

* WIP begin fixing test_network_task

* tidy use statement

* todos

* fix test_network_task (no idea why it works now)

* add TODOs for #1685

* clippy pacification and link to #1686

* clippy pacification

* [no ci] log unexpected events

* [no ci] demote a few noisy error logs

* fix test_web_server

* lint

* [no ci] link to #1690

* [no ci] remove duplicate issue link

* [no ci] link to #1691

* [no ci] link to EspressoSystems/jellyfish#369

* [no ci] link to #1692

* [no ci] another link to #1686

* don't make release builds

* [no ci] link to #1693

* [no ci] link to #1695

* demote another noisy error log

* lint argh ci is killing me

* [no ci] link to #1696

* [no ci] link to #1697

* [no ci] link to #1698

* [no ci] link to #1699

* [no ci] link to #1700

* [no ci] link to #1701

* [no ci] link to #1702

* [no ci] link to #1703

* [no ci] cover my tracks

* [no ci] link to #1704

* allow test more time to pass ci :fingers-crossed:

* more time for web_server, basic tests to complete

* address #1684 (comment)

* allow more time for tests to pass

* address #1684 (comment)

* experiment: restore use of release build for tests

* add commented code that hangs test

* remove release build again

* WIP toward a fix for #1695

* add commitment member to VidDisperse, ensure Proposal.signature matches the commitment

* use the correct commitment in VidDisperseRecv, update comments

* restore commented code to check whether I'm the VID leader

* add sanity log msg and TODO

* tidy logs and comments

* add VidVote message purpose

* message type Vid (unimplemented) -> VidDisperse (now implemented)

* VidCert message type

* restore original test timeout durations, #1713 now fixed

* type: VidCert use cert route

* more time for tests to complete

* [no ci] more comment links to github issues

* [no ci] comment link to #1717

* add commented VID test code

* close #1697, fix test with VID

* make_vote_token failure should cause test to fail

* fix #1717

* add ASYNC_STD_THREAD_COUNT=1 to test_success, test_web_server, test_consensus_task
@ggutoski ggutoski changed the title T4.1: Proper source for VID number of storage nodes T3.1: Proper source for VID number of storage nodes Oct 3, 2023
@ggutoski ggutoski changed the title T3.1: Proper source for VID number of storage nodes Proper source for VID number of storage nodes Oct 5, 2023
@rob-maron rob-maron reopened this Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants