Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GHA] Add timeouts and run x86_64 macOS jobs on native hardware #2273

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

giordano
Copy link
Member

x86_64 macOS test jobs are timing out, and the default timeout is an unreasonable 6 hours, which clogs up the queue in the entire GitHub organisation. This PR sets lower timeouts for individual CI jobs (2 hours for the tests), also makes x86_64 macOS jobs run on native hardware instead of going through Rosetta, which may or may not be the cause of the hangs.

Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.36%. Comparing base (037dfed) to head (ca8f7f7).
Report is 340 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2273      +/-   ##
==========================================
+ Coverage   67.50%   75.36%   +7.85%     
==========================================
  Files          31       56      +25     
  Lines       12668    16734    +4066     
==========================================
+ Hits         8552    12612    +4060     
- Misses       4116     4122       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giordano
Copy link
Member Author

instead of going through Rosetta, which may or may not be the cause of the hangs.

Actually, I'm somewhat positive the issue is using Rosetta, since the last message printed is

rosetta error: unexpectedly need to EmulateForward on a synchronous exception x86_rip=0x4483051488 arm_pc=0x4491036424 num_insts=4 inst_index=3 x86 instruction bytes: 0x6215344901283465301 0x18125098399031709779

@giordano
Copy link
Member Author

And just to confirm this does fix the issue: https://github.com/EnzymeAD/Enzyme.jl/actions/runs/12843787914/job/35816114301?pr=2273 finished in 40 minutes without errors 🙂

@wsmoses
Copy link
Member

wsmoses commented Jan 18, 2025

oh awesome!

@wsmoses wsmoses merged commit 9406ed8 into EnzymeAD:main Jan 18, 2025
26 of 30 checks passed
@giordano giordano deleted the mg/gha-timeout branch January 18, 2025 15:33
@danielwe
Copy link
Contributor

Why not keep the arm64 macOS instances and run natively instead of through Rosetta?

@giordano
Copy link
Member Author

This PR was minimally changing and meant only to make existing setup working without errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants