Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big number of operations, overflow the display #48

Open
airvzxf opened this issue Oct 16, 2022 · 7 comments
Open

Big number of operations, overflow the display #48

airvzxf opened this issue Oct 16, 2022 · 7 comments

Comments

@airvzxf
Copy link
Contributor

airvzxf commented Oct 16, 2022

Since the calculator allow to the user to add any number of operations, for example: “54+4548548+5445+455848+45168”. In the case that the user add a big formula, the numbers overflow from the white rectangle, also I noticed that the operations are displaying below, and it causes the same effect overriding the calculator buttons.

image

I suggest adding a text area for the operations inputs, or use the scroll property in the div but in any case is important to review in different browsers, OS, and devices (mobile, tablet, desktop).

Quick Note: If you add this issue with the Hacktoberfest label, I am able to check and fix it.

@Emilance
Copy link
Owner

Okay @airvzxf , thanks for raising this issue, I will assign this to you

@airvzxf
Copy link
Contributor Author

airvzxf commented Oct 19, 2022

The solution came with two options.

  1. Use ellipsis to cut the long text. The advantage is that it looks beautiful. The disadvantage is that the user can't see the long “formula”.
    image

  2. Use horizontal scroll. The advantage is that the user can see the long “formula”. The disadvantage is that it does not look beautiful.
    image

What approach did you prefer?

@airvzxf
Copy link
Contributor Author

airvzxf commented Oct 21, 2022

Hi, @Emilance. I wonder if you reviewed the options. You only need to choose between option 1 or 2. The first one is related to use ellipses to truncate the big formula. The second one is using a horizontal scroll.

@airvzxf
Copy link
Contributor Author

airvzxf commented Oct 22, 2022

Hi, again @Emilance, I will take the option of the scroll.

@airvzxf
Copy link
Contributor Author

airvzxf commented Oct 27, 2022

Hi, @Emilance. Some news for this issue and the pull request?

@airvzxf
Copy link
Contributor Author

airvzxf commented Oct 27, 2022

Hi, @Emilance. Some comments for this issue and the pull request?

@airvzxf
Copy link
Contributor Author

airvzxf commented Oct 29, 2022

Hi, @Emilance. Do you have a lot of work? Or do you little abandon this repository? Or do you want to avoid these changes? The Hacktoberfest fest is almost close and this PR count for my profile progress.

Does that look you won't merge before 31 of October? It is little sad for all the effort that I did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants