-
Notifications
You must be signed in to change notification settings - Fork 0
React 19.2 #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 19.2 #10
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
✅ Deploy Preview for react-responsive-overflow-list ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on December 24
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Bug: React Activity Removal Undermines React 19+ Benefits
The removal of React.Activity component usage breaks the intended React 19.2+ feature. The code previously wrapped hidden items with Activity to keep them mounted while toggling visibility, but now always unmounts them by returning null. This contradicts the documented behavior and defeats the benefit of upgrading to React 19.2+, where hidden items should remain mounted via Activity to avoid state loss and flickering when children change sizes.
src/components/OverflowList.tsx#L229-L235
react-responsive-overflow-list/src/components/OverflowList.tsx
Lines 229 to 235 in 48204c9
| const finalRenderItemVisibility = | |
| renderItemVisibility ?? | |
| ((node, meta) => { | |
| if (!meta.visible) return null; | |
| return <React.Fragment key={meta.index}>{node}</React.Fragment>; | |
| }); |
|
closing as its just for demo for possible react bug |
Note
Simplifies OverflowList visibility handling by removing React.Activity and pins workspace React packages to ~19.2.0.
src/components/OverflowList.tsx:renderItemVisibility: removesReact.Activityusage and returnsnullfor non-visible items,Fragmentfor visible ones.pnpm-workspace.yaml: Pins catalog entries forreact,react-dom,@types/react,@types/react-domfrom caret to tilde (~19.2.0).Written by Cursor Bugbot for commit 48204c9. This will update automatically on new commits. Configure here.