lightning-cli: fix malformed response bug #7924
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a wrong assumption that the number of bytes read by `cli_read` would get us for each correctly read token two extra CR characters. As a matter of fact one could read enough characters to parse the first token, but the two extra CR characters are not guaranteed. Changelog-Fixed: lightning-cli: fix "malformed response" bug Signed-off-by: Lagrang3 <[email protected]>
Lagrang3
force-pushed
the
lightning-cli-malformed-response
branch
from
8089be7 to
0ef3fb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog-Fixed: lightning-cli: fix "malformed response" bug
Fixes #7904
There was a wrong assumption that the number of bytes read by
cli_readwould get us for each correctlyread token two extra CR characters. As a matter of fact one could read enough characters to parse the first
token, but the two extra CR characters are not guaranteed.