Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/leave should require confirmation when participating in a game #90

Open
FRQDO opened this issue Mar 29, 2020 · 2 comments
Open

/leave should require confirmation when participating in a game #90

FRQDO opened this issue Mar 29, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@FRQDO
Copy link
Collaborator

FRQDO commented Mar 29, 2020

Players can destroy a running game by accidentally tapping the /leave command suggestion instead of /logs.

Leaving a game without having to confirm should only be possible if

  • Leaving player is a spectator
  • Leaving player is dead
  • Game is in state ACCEPT_PLAYERS
  • Game is in state GAME_OVER
@FRQDO FRQDO added the enhancement New feature or request label Mar 29, 2020
@DerMolly
Copy link
Collaborator

What should the syntax be like?
Like the /restart confirm Command or should the bot message the person privately and display the question with options like policy picks?

@FRQDO
Copy link
Collaborator Author

FRQDO commented Mar 31, 2020

Commands that require a conscious choice and are not used as frequently as, for instance, /enact F (e.g. really restarting the bot even though it cancels running games) should always require users to type them out, I think.
Otherwise, we merely add a second layer of “oops I accidentally touched the wrong thing” protection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants