Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output enable not working as expected #189

Open
fletsche opened this issue Nov 26, 2018 · 2 comments · May be fixed by #207
Open

Output enable not working as expected #189

fletsche opened this issue Nov 26, 2018 · 2 comments · May be fixed by #207

Comments

@fletsche
Copy link

I did some testing with the shutdown/shutdownx pins and found out that they do not work as expected. It seems that there are at least two issues:
1.) In VS1053::startSong output was enabled regardless of the current volume (I fixed this in pull request #188).

2.) When issuing the "stop" command the shutdown pin is activated but only for about one second, then it somehow gets deactivated and I could not yet figure out where or why. I hope Edzelf can help with that one!
@Pavulon87
Copy link

I see this problem too. Its because handle_spec() sets volume immediately / infinitely.
vs1053player->setVolume ( ini_block.reqvol ) ; // Unmute
Quick fix. In VS1053::setVolume I added:
if ( vol && ( datamode & ( STOPREQD | STOPPED ) ) ) { return; }

@fletsche
Copy link
Author

fletsche commented Jan 2, 2019

I tried your quick fix. It has the side effect that the volume cannot be changed, when playback is stopped. I took a deeper look into the volume controll at it seems to me, that muting is a bit of a hack anyway. I think for a real solution it would be necessary to strictly differentiate between desired volume, mute state and amplifier shutdown.
Shutdown is actually a little more complex as it depends on the recovery of the amp from shutdown. I. e. the PAM8403 has separate mute and shutdown pins. While both pins react instantaneous to mute the output at least in my experience it took a few seconds after enabling the amp via the shutdown pin until output was audible.

@fletsche fletsche linked a pull request Jan 2, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New amp shutdown control fletsche/ESP32-Radio
2 participants
@Pavulon87 @fletsche