Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEC style IR repeat codes are not detected #205

Open
fletsche opened this issue Dec 30, 2018 · 0 comments · May be fixed by #206
Open

NEC style IR repeat codes are not detected #205

fletsche opened this issue Dec 30, 2018 · 0 comments · May be fixed by #206

Comments

@fletsche
Copy link

fletsche commented Dec 30, 2018

The current implementation of IR code recognition is only able to detect complete IR frames (65 level changes). However many remotes send the complete code only once per keypress. If the key is held for a longer duration a special repeat code is sent. NEC IR Protocol
This doesn't get recognized by the current routine and even if it were the interpretation of the repeat code isn't completely trivial. I.e. some in some commands a repeat doesn't make sense (mute) in some it makes more sense (preset +) and in some it makes a lot of sense (volume +/-). It even might be confusing to some users if this functionality is missing, as the standard behavior of consumer electronic devices is to increase/decrease volume as long as the rc button is held.

@fletsche fletsche linked a pull request Dec 30, 2018 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant