Skip to content

Commit bdd58e4

Browse files
authored
Merge pull request #226 from Ecwid/usa-taxes
Add taxType to OrderItemTax
2 parents 91ceac0 + 3074389 commit bdd58e4

File tree

5 files changed

+23
-6
lines changed

5 files changed

+23
-6
lines changed

src/main/kotlin/com/ecwid/apiclient/v3/converter/FetchedOrder.kt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,8 @@ fun FetchedOrder.OrderItemTax.toUpdated(): UpdatedOrder.OrderItemTax {
187187
total = total,
188188
taxOnDiscountedSubtotal = taxOnDiscountedSubtotal,
189189
taxOnShipping = taxOnShipping,
190-
includeInPrice = includeInPrice
190+
includeInPrice = includeInPrice,
191+
taxType = taxType,
191192
)
192193
}
193194

@@ -258,7 +259,8 @@ fun FetchedOrder.BaseOrderItemTax.toUpdated(): UpdatedOrder.BaseOrderItemTax {
258259
return UpdatedOrder.BaseOrderItemTax(
259260
name = name,
260261
value = value,
261-
total = total
262+
total = total,
263+
taxType = taxType,
262264
)
263265
}
264266

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
package com.ecwid.apiclient.v3.dto.order.enums
2+
3+
@Suppress("unused")
4+
enum class OrderItemTaxType {
5+
STATE,
6+
COUNTY,
7+
CITY,
8+
SPECIAL_DISTRICT,
9+
}

src/main/kotlin/com/ecwid/apiclient/v3/dto/order/request/UpdatedOrder.kt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,8 @@ data class UpdatedOrder(
241241
data class BaseOrderItemTax(
242242
override val name: String? = null,
243243
override val value: Double? = null,
244-
override val total: Double? = null
244+
override val total: Double? = null,
245+
val taxType: OrderItemTaxType? = null,
245246
) : BaseOrderTax
246247

247248
data class OrderItemTax(
@@ -250,7 +251,8 @@ data class UpdatedOrder(
250251
override val total: Double? = null,
251252
val taxOnDiscountedSubtotal: Double? = null,
252253
val taxOnShipping: Double? = null,
253-
val includeInPrice: Boolean? = null
254+
val includeInPrice: Boolean? = null,
255+
val taxType: OrderItemTaxType? = null,
254256
) : BaseOrderTax
255257

256258
data class HandlingFeeTax(

src/main/kotlin/com/ecwid/apiclient/v3/dto/order/result/FetchedOrder.kt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,8 @@ data class FetchedOrder(
226226
data class BaseOrderItemTax(
227227
override val name: String? = null,
228228
override val value: Double? = null,
229-
override val total: Double? = null
229+
override val total: Double? = null,
230+
val taxType: OrderItemTaxType? = null,
230231
) : BaseOrderTax
231232

232233
data class OrderItemTax(
@@ -237,7 +238,8 @@ data class FetchedOrder(
237238
val taxOnShipping: Double? = null,
238239
val includeInPrice: Boolean? = null,
239240
val sourceTaxRateId: Int? = null,
240-
val sourceTaxRateType: RateType? = null
241+
val sourceTaxRateType: RateType? = null,
242+
val taxType: OrderItemTaxType? = null,
241243
) : BaseOrderTax {
242244
enum class RateType {
243245
AUTO,

src/test/kotlin/com/ecwid/apiclient/v3/rule/nullablepropertyrules/FetchedOrderRules.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ val fetchedOrderNullablePropertyRules: List<NullablePropertyRule<*, *>> = listOf
99
AllowNullable(FetchedOrder.BaseOrderItemTax::name),
1010
AllowNullable(FetchedOrder.BaseOrderItemTax::total),
1111
AllowNullable(FetchedOrder.BaseOrderItemTax::value),
12+
AllowNullable(FetchedOrder.BaseOrderItemTax::taxType),
1213
AllowNullable(FetchedOrder.HandlingFeeTax::name),
1314
AllowNullable(FetchedOrder.HandlingFeeTax::total),
1415
AllowNullable(FetchedOrder.HandlingFeeTax::value),
@@ -126,6 +127,7 @@ val fetchedOrderNullablePropertyRules: List<NullablePropertyRule<*, *>> = listOf
126127
IgnoreNullable(FetchedOrder.OrderItemTax::value),
127128
IgnoreNullable(FetchedOrder.OrderItemTax::sourceTaxRateId),
128129
IgnoreNullable(FetchedOrder.OrderItemTax::sourceTaxRateType),
130+
AllowNullable(FetchedOrder.OrderItemTax::taxType),
129131
AllowNullable(FetchedOrder.Parcel::dimensionUnit),
130132
AllowNullable(FetchedOrder.Parcel::height),
131133
AllowNullable(FetchedOrder.Parcel::length),

0 commit comments

Comments
 (0)