Spaces in names #98
Description
In #94 locations are created with spaces in their name. Instead underscores should be used. Two comments reflecting this:
There should be some unintended consequences of allowing spaces in names. I can't quickly think of any programming language that allows spaces in names.Originally posted by @magoorden in #94 (comment)
I think it is dangerous to allow spaces in names. I think we should stick to having _ (underscores in the names).
--ulrik On 05/02/2023 08.56, Andreas K. Brandhøj wrote: @Brandhoej commented on this pull request.
________________________________ In src/logic/Refinement.java<#94 (comment)>:
@@ -432,8 +432,9 @@ private boolean checkActions(State state1, State state2, boolean isInput) {
Log.debug("create pairs failed"); if (RET_REF) { - Location ll = Location.createInconsistentLocation("inconsistent", 0, 0); - Location rl = Location.createInconsistentLocation("inconsistent", 0, 0); + Clock inconsistentClock = new Clock("inconsistent clock", "refinement"); I don't know how parsing is affected by spaces in names, but I would prefer to allow them. — Reply to this email directly, view it on GitHub<#94 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADBJZC23UDCI6PYWGUQP7CDWV5MLDANCNFSM6AAAAAASOQYU7Y. You are receiving this because you are subscribed to this thread.Message ID: @.***>
…
-- ⬡ Ulrik Nyman, http://ulrik.blog.aau.dk, mobile: (+45) 40 89 21 56 ⩽ Associate Professor, Ph.D. Head of Studies at Department of Computer Science Deputy Head of Department, http://www.cs.aau.dk Education Coordinator for Software Aalborg University, http://www.aau.dk
We should disallow spaces in Location and possibly also Automaton names. This should probably be fixed after #97 has been introduced.