From 5ebdd281865f25b325f8eeaf606428ef483d975e Mon Sep 17 00:00:00 2001 From: Haipeng Lin Date: Tue, 26 Aug 2025 23:59:23 -0400 Subject: [PATCH 1/3] Fix crash in physics_check_data when registry variable has initial_value but not read from file, but is modified (intent out) from physics scheme This is a proposed fix for a corner case where a variable is introduced into the CAM registry that has an initial_value but never read from file, as well as having an intent(out) or intent(inout) from a physics scheme. Such a case might happen because a variable might only be set in a scheme's "init" phase, yet used for "run" phases, and thus necessitates its introduction into the registry to persist state across timesteps. However, because this variable needs to be set in the scheme's "init" phase (and thus has intent(out)) it triggers the physics data check routine. The physics_check_data select case uses the find_input_name_idx to retrieve the name_idx, which is then used to get the actual input name, via phys_var_stdnames(name_idx); however, if a variable is intent(out) yet never read from file, find_input_name_idx in physics_data.F90 returns init_mark_idx = -2, which is out of bounds for phys_var_stdnames, and yet not covered by the guard case statements in the select case in physics_check_data; this commit adds the guard case for init_mark_idx with a comment to denote the corner case's triggering conditions. --- src/data/write_init_files.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/data/write_init_files.py b/src/data/write_init_files.py index 17e1e8e4a..6f8b46408 100644 --- a/src/data/write_init_files.py +++ b/src/data/write_init_files.py @@ -1415,6 +1415,12 @@ def write_phys_check_subroutine(outfile, host_dict, host_vars, host_imports, outfile.comment("If variable is a constituent, then do nothing. We'll handle these later", 6) outfile.blank_line() + # Skip already initialized variables: + outfile.write("case (init_mark_idx)", 5) + outfile.blank_line() + outfile.comment("If variable only has an initial_value but not read from file, then do nothing, even if it is modified by the physics scheme. There is nothing we can check against.", 6) + outfile.blank_line() + # Generate error message if required variable isn't found: outfile.write("case (no_exist_idx)", 5) outfile.blank_line() From ecb38b6ea98941dccd75e48ac4070ccbe56ac5ae Mon Sep 17 00:00:00 2001 From: Haipeng Lin Date: Fri, 26 Sep 2025 11:30:28 -0400 Subject: [PATCH 2/3] Update sample files --- .../sample_files/write_init_files/physics_inputs_4D.F90 | 5 +++++ .../sample_files/write_init_files/physics_inputs_bvd.F90 | 5 +++++ .../sample_files/write_init_files/physics_inputs_cnst.F90 | 5 +++++ .../write_init_files/physics_inputs_constituent_dim.F90 | 5 +++++ .../sample_files/write_init_files/physics_inputs_ddt.F90 | 5 +++++ .../sample_files/write_init_files/physics_inputs_ddt2.F90 | 5 +++++ .../write_init_files/physics_inputs_ddt_array.F90 | 5 +++++ .../write_init_files/physics_inputs_host_var.F90 | 5 +++++ .../write_init_files/physics_inputs_initial_value.F90 | 5 +++++ .../sample_files/write_init_files/physics_inputs_mf.F90 | 5 +++++ .../write_init_files/physics_inputs_no_horiz.F90 | 5 +++++ .../sample_files/write_init_files/physics_inputs_noreq.F90 | 5 +++++ .../sample_files/write_init_files/physics_inputs_param.F90 | 5 +++++ .../sample_files/write_init_files/physics_inputs_protect.F90 | 5 +++++ .../sample_files/write_init_files/physics_inputs_scalar.F90 | 5 +++++ .../sample_files/write_init_files/physics_inputs_simple.F90 | 5 +++++ 16 files changed, 80 insertions(+) diff --git a/test/unit/python/sample_files/write_init_files/physics_inputs_4D.F90 b/test/unit/python/sample_files/write_init_files/physics_inputs_4D.F90 index 0cde34503..ffb0ba66c 100644 --- a/test/unit/python/sample_files/write_init_files/physics_inputs_4D.F90 +++ b/test/unit/python/sample_files/write_init_files/physics_inputs_4D.F90 @@ -319,6 +319,11 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference, ! If variable is a constituent, then do nothing. We'll handle these later + case (init_mark_idx) + + ! If variable only has an initial_value but not read from file, then do nothing, even if it is modified by the physics scheme. + ! There is nothing we can check against. + case (no_exist_idx) ! If the index for an output variable was not found, then do nothing. We won't try to check these. diff --git a/test/unit/python/sample_files/write_init_files/physics_inputs_bvd.F90 b/test/unit/python/sample_files/write_init_files/physics_inputs_bvd.F90 index 277616dbf..64b676a8e 100644 --- a/test/unit/python/sample_files/write_init_files/physics_inputs_bvd.F90 +++ b/test/unit/python/sample_files/write_init_files/physics_inputs_bvd.F90 @@ -319,6 +319,11 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference, ! If variable is a constituent, then do nothing. We'll handle these later + case (init_mark_idx) + + ! If variable only has an initial_value but not read from file, then do nothing, even if it is modified by the physics scheme. + ! There is nothing we can check against. + case (no_exist_idx) ! If the index for an output variable was not found, then do nothing. We won't try to check these. diff --git a/test/unit/python/sample_files/write_init_files/physics_inputs_cnst.F90 b/test/unit/python/sample_files/write_init_files/physics_inputs_cnst.F90 index 5774861bf..fdd063a2a 100644 --- a/test/unit/python/sample_files/write_init_files/physics_inputs_cnst.F90 +++ b/test/unit/python/sample_files/write_init_files/physics_inputs_cnst.F90 @@ -319,6 +319,11 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference, ! If variable is a constituent, then do nothing. We'll handle these later + case (init_mark_idx) + + ! If variable only has an initial_value but not read from file, then do nothing, even if it is modified by the physics scheme. + ! There is nothing we can check against. + case (no_exist_idx) ! If the index for an output variable was not found, then do nothing. We won't try to check these. diff --git a/test/unit/python/sample_files/write_init_files/physics_inputs_constituent_dim.F90 b/test/unit/python/sample_files/write_init_files/physics_inputs_constituent_dim.F90 index 417e02dec..245a63c1c 100644 --- a/test/unit/python/sample_files/write_init_files/physics_inputs_constituent_dim.F90 +++ b/test/unit/python/sample_files/write_init_files/physics_inputs_constituent_dim.F90 @@ -327,6 +327,11 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference, ! If variable is a constituent, then do nothing. We'll handle these later + case (init_mark_idx) + + ! If variable only has an initial_value but not read from file, then do nothing, even if it is modified by the physics scheme. + ! There is nothing we can check against. + case (no_exist_idx) ! If the index for an output variable was not found, then do nothing. We won't try to check these. diff --git a/test/unit/python/sample_files/write_init_files/physics_inputs_ddt.F90 b/test/unit/python/sample_files/write_init_files/physics_inputs_ddt.F90 index 72718c91d..ffab9c0e8 100644 --- a/test/unit/python/sample_files/write_init_files/physics_inputs_ddt.F90 +++ b/test/unit/python/sample_files/write_init_files/physics_inputs_ddt.F90 @@ -319,6 +319,11 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference, ! If variable is a constituent, then do nothing. We'll handle these later + case (init_mark_idx) + + ! If variable only has an initial_value but not read from file, then do nothing, even if it is modified by the physics scheme. + ! There is nothing we can check against. + case (no_exist_idx) ! If the index for an output variable was not found, then do nothing. We won't try to check these. diff --git a/test/unit/python/sample_files/write_init_files/physics_inputs_ddt2.F90 b/test/unit/python/sample_files/write_init_files/physics_inputs_ddt2.F90 index 73407ccad..b3696db41 100644 --- a/test/unit/python/sample_files/write_init_files/physics_inputs_ddt2.F90 +++ b/test/unit/python/sample_files/write_init_files/physics_inputs_ddt2.F90 @@ -319,6 +319,11 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference, ! If variable is a constituent, then do nothing. We'll handle these later + case (init_mark_idx) + + ! If variable only has an initial_value but not read from file, then do nothing, even if it is modified by the physics scheme. + ! There is nothing we can check against. + case (no_exist_idx) ! If the index for an output variable was not found, then do nothing. We won't try to check these. diff --git a/test/unit/python/sample_files/write_init_files/physics_inputs_ddt_array.F90 b/test/unit/python/sample_files/write_init_files/physics_inputs_ddt_array.F90 index f03012115..0153077d3 100644 --- a/test/unit/python/sample_files/write_init_files/physics_inputs_ddt_array.F90 +++ b/test/unit/python/sample_files/write_init_files/physics_inputs_ddt_array.F90 @@ -319,6 +319,11 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference, ! If variable is a constituent, then do nothing. We'll handle these later + case (init_mark_idx) + + ! If variable only has an initial_value but not read from file, then do nothing, even if it is modified by the physics scheme. + ! There is nothing we can check against. + case (no_exist_idx) ! If the index for an output variable was not found, then do nothing. We won't try to check these. diff --git a/test/unit/python/sample_files/write_init_files/physics_inputs_host_var.F90 b/test/unit/python/sample_files/write_init_files/physics_inputs_host_var.F90 index a55d982cf..24932338b 100644 --- a/test/unit/python/sample_files/write_init_files/physics_inputs_host_var.F90 +++ b/test/unit/python/sample_files/write_init_files/physics_inputs_host_var.F90 @@ -315,6 +315,11 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference, ! If variable is a constituent, then do nothing. We'll handle these later + case (init_mark_idx) + + ! If variable only has an initial_value but not read from file, then do nothing, even if it is modified by the physics scheme. + ! There is nothing we can check against. + case (no_exist_idx) ! If the index for an output variable was not found, then do nothing. We won't try to check these. diff --git a/test/unit/python/sample_files/write_init_files/physics_inputs_initial_value.F90 b/test/unit/python/sample_files/write_init_files/physics_inputs_initial_value.F90 index 406bbc736..01424c1bd 100644 --- a/test/unit/python/sample_files/write_init_files/physics_inputs_initial_value.F90 +++ b/test/unit/python/sample_files/write_init_files/physics_inputs_initial_value.F90 @@ -319,6 +319,11 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference, ! If variable is a constituent, then do nothing. We'll handle these later + case (init_mark_idx) + + ! If variable only has an initial_value but not read from file, then do nothing, even if it is modified by the physics scheme. + ! There is nothing we can check against. + case (no_exist_idx) ! If the index for an output variable was not found, then do nothing. We won't try to check these. diff --git a/test/unit/python/sample_files/write_init_files/physics_inputs_mf.F90 b/test/unit/python/sample_files/write_init_files/physics_inputs_mf.F90 index 300628060..678021e4d 100644 --- a/test/unit/python/sample_files/write_init_files/physics_inputs_mf.F90 +++ b/test/unit/python/sample_files/write_init_files/physics_inputs_mf.F90 @@ -320,6 +320,11 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference, ! If variable is a constituent, then do nothing. We'll handle these later + case (init_mark_idx) + + ! If variable only has an initial_value but not read from file, then do nothing, even if it is modified by the physics scheme. + ! There is nothing we can check against. + case (no_exist_idx) ! If the index for an output variable was not found, then do nothing. We won't try to check these. diff --git a/test/unit/python/sample_files/write_init_files/physics_inputs_no_horiz.F90 b/test/unit/python/sample_files/write_init_files/physics_inputs_no_horiz.F90 index 35e5260f2..7e855e14b 100644 --- a/test/unit/python/sample_files/write_init_files/physics_inputs_no_horiz.F90 +++ b/test/unit/python/sample_files/write_init_files/physics_inputs_no_horiz.F90 @@ -319,6 +319,11 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference, ! If variable is a constituent, then do nothing. We'll handle these later + case (init_mark_idx) + + ! If variable only has an initial_value but not read from file, then do nothing, even if it is modified by the physics scheme. + ! There is nothing we can check against. + case (no_exist_idx) ! If the index for an output variable was not found, then do nothing. We won't try to check these. diff --git a/test/unit/python/sample_files/write_init_files/physics_inputs_noreq.F90 b/test/unit/python/sample_files/write_init_files/physics_inputs_noreq.F90 index 978046720..8cb1892bf 100644 --- a/test/unit/python/sample_files/write_init_files/physics_inputs_noreq.F90 +++ b/test/unit/python/sample_files/write_init_files/physics_inputs_noreq.F90 @@ -311,6 +311,11 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference, ! If variable is a constituent, then do nothing. We'll handle these later + case (init_mark_idx) + + ! If variable only has an initial_value but not read from file, then do nothing, even if it is modified by the physics scheme. + ! There is nothing we can check against. + case (no_exist_idx) ! If the index for an output variable was not found, then do nothing. We won't try to check these. diff --git a/test/unit/python/sample_files/write_init_files/physics_inputs_param.F90 b/test/unit/python/sample_files/write_init_files/physics_inputs_param.F90 index 2d3ffbe52..e7cd79f03 100644 --- a/test/unit/python/sample_files/write_init_files/physics_inputs_param.F90 +++ b/test/unit/python/sample_files/write_init_files/physics_inputs_param.F90 @@ -322,6 +322,11 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference, ! If variable is a constituent, then do nothing. We'll handle these later + case (init_mark_idx) + + ! If variable only has an initial_value but not read from file, then do nothing, even if it is modified by the physics scheme. + ! There is nothing we can check against. + case (no_exist_idx) ! If the index for an output variable was not found, then do nothing. We won't try to check these. diff --git a/test/unit/python/sample_files/write_init_files/physics_inputs_protect.F90 b/test/unit/python/sample_files/write_init_files/physics_inputs_protect.F90 index e7c899f0e..b8baaa0cb 100644 --- a/test/unit/python/sample_files/write_init_files/physics_inputs_protect.F90 +++ b/test/unit/python/sample_files/write_init_files/physics_inputs_protect.F90 @@ -319,6 +319,11 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference, ! If variable is a constituent, then do nothing. We'll handle these later + case (init_mark_idx) + + ! If variable only has an initial_value but not read from file, then do nothing, even if it is modified by the physics scheme. + ! There is nothing we can check against. + case (no_exist_idx) ! If the index for an output variable was not found, then do nothing. We won't try to check these. diff --git a/test/unit/python/sample_files/write_init_files/physics_inputs_scalar.F90 b/test/unit/python/sample_files/write_init_files/physics_inputs_scalar.F90 index 28b64a837..ef334cca5 100644 --- a/test/unit/python/sample_files/write_init_files/physics_inputs_scalar.F90 +++ b/test/unit/python/sample_files/write_init_files/physics_inputs_scalar.F90 @@ -319,6 +319,11 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference, ! If variable is a constituent, then do nothing. We'll handle these later + case (init_mark_idx) + + ! If variable only has an initial_value but not read from file, then do nothing, even if it is modified by the physics scheme. + ! There is nothing we can check against. + case (no_exist_idx) ! If the index for an output variable was not found, then do nothing. We won't try to check these. diff --git a/test/unit/python/sample_files/write_init_files/physics_inputs_simple.F90 b/test/unit/python/sample_files/write_init_files/physics_inputs_simple.F90 index fb07ef005..c02efc98f 100644 --- a/test/unit/python/sample_files/write_init_files/physics_inputs_simple.F90 +++ b/test/unit/python/sample_files/write_init_files/physics_inputs_simple.F90 @@ -319,6 +319,11 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference, ! If variable is a constituent, then do nothing. We'll handle these later + case (init_mark_idx) + + ! If variable only has an initial_value but not read from file, then do nothing, even if it is modified by the physics scheme. + ! There is nothing we can check against. + case (no_exist_idx) ! If the index for an output variable was not found, then do nothing. We won't try to check these. From 19e954fb8d0157a5cac56d2b77c84678b51fe608 Mon Sep 17 00:00:00 2001 From: Haipeng Lin Date: Fri, 26 Sep 2025 12:58:54 -0400 Subject: [PATCH 3/3] Add missing periods at end of sentence --- src/data/write_init_files.py | 4 ++-- .../sample_files/write_init_files/physics_inputs_4D.F90 | 4 ++-- .../sample_files/write_init_files/physics_inputs_bvd.F90 | 4 ++-- .../sample_files/write_init_files/physics_inputs_cnst.F90 | 4 ++-- .../write_init_files/physics_inputs_constituent_dim.F90 | 4 ++-- .../sample_files/write_init_files/physics_inputs_ddt.F90 | 4 ++-- .../sample_files/write_init_files/physics_inputs_ddt2.F90 | 4 ++-- .../write_init_files/physics_inputs_ddt_array.F90 | 4 ++-- .../sample_files/write_init_files/physics_inputs_host_var.F90 | 4 ++-- .../write_init_files/physics_inputs_initial_value.F90 | 4 ++-- .../sample_files/write_init_files/physics_inputs_mf.F90 | 4 ++-- .../sample_files/write_init_files/physics_inputs_no_horiz.F90 | 4 ++-- .../sample_files/write_init_files/physics_inputs_noreq.F90 | 4 ++-- .../sample_files/write_init_files/physics_inputs_param.F90 | 4 ++-- .../sample_files/write_init_files/physics_inputs_protect.F90 | 4 ++-- .../sample_files/write_init_files/physics_inputs_scalar.F90 | 4 ++-- .../sample_files/write_init_files/physics_inputs_simple.F90 | 4 ++-- 17 files changed, 34 insertions(+), 34 deletions(-) diff --git a/src/data/write_init_files.py b/src/data/write_init_files.py index 6f8b46408..838c5f1b0 100644 --- a/src/data/write_init_files.py +++ b/src/data/write_init_files.py @@ -1099,7 +1099,7 @@ def write_phys_read_subroutine(outfile, host_dict, host_vars, host_imports, # Handle the case where the required variable is a constituent outfile.write("case (const_idx)", 5) outfile.blank_line() - outfile.comment("If an index was found in the constituent hash table, then do nothing, this will be handled later", 6) + outfile.comment("If an index was found in the constituent hash table, then do nothing, this will be handled later.", 6) outfile.blank_line() # start default case steps: @@ -1412,7 +1412,7 @@ def write_phys_check_subroutine(outfile, host_dict, host_vars, host_imports, # Skip constituent variables: outfile.write("case (const_idx)", 5) outfile.blank_line() - outfile.comment("If variable is a constituent, then do nothing. We'll handle these later", 6) + outfile.comment("If variable is a constituent, then do nothing. We'll handle these later.", 6) outfile.blank_line() # Skip already initialized variables: diff --git a/test/unit/python/sample_files/write_init_files/physics_inputs_4D.F90 b/test/unit/python/sample_files/write_init_files/physics_inputs_4D.F90 index ffb0ba66c..d3326cfc4 100644 --- a/test/unit/python/sample_files/write_init_files/physics_inputs_4D.F90 +++ b/test/unit/python/sample_files/write_init_files/physics_inputs_4D.F90 @@ -139,7 +139,7 @@ subroutine physics_read_data(file, suite_names, timestep, read_initialized_varia case (const_idx) - ! If an index was found in the constituent hash table, then do nothing, this will be handled later + ! If an index was found in the constituent hash table, then do nothing, this will be handled later. case default @@ -317,7 +317,7 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference, case (const_idx) - ! If variable is a constituent, then do nothing. We'll handle these later + ! If variable is a constituent, then do nothing. We'll handle these later. case (init_mark_idx) diff --git a/test/unit/python/sample_files/write_init_files/physics_inputs_bvd.F90 b/test/unit/python/sample_files/write_init_files/physics_inputs_bvd.F90 index 64b676a8e..4d5020972 100644 --- a/test/unit/python/sample_files/write_init_files/physics_inputs_bvd.F90 +++ b/test/unit/python/sample_files/write_init_files/physics_inputs_bvd.F90 @@ -139,7 +139,7 @@ subroutine physics_read_data(file, suite_names, timestep, read_initialized_varia case (const_idx) - ! If an index was found in the constituent hash table, then do nothing, this will be handled later + ! If an index was found in the constituent hash table, then do nothing, this will be handled later. case default @@ -317,7 +317,7 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference, case (const_idx) - ! If variable is a constituent, then do nothing. We'll handle these later + ! If variable is a constituent, then do nothing. We'll handle these later. case (init_mark_idx) diff --git a/test/unit/python/sample_files/write_init_files/physics_inputs_cnst.F90 b/test/unit/python/sample_files/write_init_files/physics_inputs_cnst.F90 index fdd063a2a..836b44d1c 100644 --- a/test/unit/python/sample_files/write_init_files/physics_inputs_cnst.F90 +++ b/test/unit/python/sample_files/write_init_files/physics_inputs_cnst.F90 @@ -139,7 +139,7 @@ subroutine physics_read_data(file, suite_names, timestep, read_initialized_varia case (const_idx) - ! If an index was found in the constituent hash table, then do nothing, this will be handled later + ! If an index was found in the constituent hash table, then do nothing, this will be handled later. case default @@ -317,7 +317,7 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference, case (const_idx) - ! If variable is a constituent, then do nothing. We'll handle these later + ! If variable is a constituent, then do nothing. We'll handle these later. case (init_mark_idx) diff --git a/test/unit/python/sample_files/write_init_files/physics_inputs_constituent_dim.F90 b/test/unit/python/sample_files/write_init_files/physics_inputs_constituent_dim.F90 index 245a63c1c..599148b16 100644 --- a/test/unit/python/sample_files/write_init_files/physics_inputs_constituent_dim.F90 +++ b/test/unit/python/sample_files/write_init_files/physics_inputs_constituent_dim.F90 @@ -139,7 +139,7 @@ subroutine physics_read_data(file, suite_names, timestep, read_initialized_varia case (const_idx) - ! If an index was found in the constituent hash table, then do nothing, this will be handled later + ! If an index was found in the constituent hash table, then do nothing, this will be handled later. case default @@ -325,7 +325,7 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference, case (const_idx) - ! If variable is a constituent, then do nothing. We'll handle these later + ! If variable is a constituent, then do nothing. We'll handle these later. case (init_mark_idx) diff --git a/test/unit/python/sample_files/write_init_files/physics_inputs_ddt.F90 b/test/unit/python/sample_files/write_init_files/physics_inputs_ddt.F90 index ffab9c0e8..c1820be82 100644 --- a/test/unit/python/sample_files/write_init_files/physics_inputs_ddt.F90 +++ b/test/unit/python/sample_files/write_init_files/physics_inputs_ddt.F90 @@ -139,7 +139,7 @@ subroutine physics_read_data(file, suite_names, timestep, read_initialized_varia case (const_idx) - ! If an index was found in the constituent hash table, then do nothing, this will be handled later + ! If an index was found in the constituent hash table, then do nothing, this will be handled later. case default @@ -317,7 +317,7 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference, case (const_idx) - ! If variable is a constituent, then do nothing. We'll handle these later + ! If variable is a constituent, then do nothing. We'll handle these later. case (init_mark_idx) diff --git a/test/unit/python/sample_files/write_init_files/physics_inputs_ddt2.F90 b/test/unit/python/sample_files/write_init_files/physics_inputs_ddt2.F90 index b3696db41..72727daf3 100644 --- a/test/unit/python/sample_files/write_init_files/physics_inputs_ddt2.F90 +++ b/test/unit/python/sample_files/write_init_files/physics_inputs_ddt2.F90 @@ -139,7 +139,7 @@ subroutine physics_read_data(file, suite_names, timestep, read_initialized_varia case (const_idx) - ! If an index was found in the constituent hash table, then do nothing, this will be handled later + ! If an index was found in the constituent hash table, then do nothing, this will be handled later. case default @@ -317,7 +317,7 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference, case (const_idx) - ! If variable is a constituent, then do nothing. We'll handle these later + ! If variable is a constituent, then do nothing. We'll handle these later. case (init_mark_idx) diff --git a/test/unit/python/sample_files/write_init_files/physics_inputs_ddt_array.F90 b/test/unit/python/sample_files/write_init_files/physics_inputs_ddt_array.F90 index 0153077d3..1e66b2f29 100644 --- a/test/unit/python/sample_files/write_init_files/physics_inputs_ddt_array.F90 +++ b/test/unit/python/sample_files/write_init_files/physics_inputs_ddt_array.F90 @@ -139,7 +139,7 @@ subroutine physics_read_data(file, suite_names, timestep, read_initialized_varia case (const_idx) - ! If an index was found in the constituent hash table, then do nothing, this will be handled later + ! If an index was found in the constituent hash table, then do nothing, this will be handled later. case default @@ -317,7 +317,7 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference, case (const_idx) - ! If variable is a constituent, then do nothing. We'll handle these later + ! If variable is a constituent, then do nothing. We'll handle these later. case (init_mark_idx) diff --git a/test/unit/python/sample_files/write_init_files/physics_inputs_host_var.F90 b/test/unit/python/sample_files/write_init_files/physics_inputs_host_var.F90 index 24932338b..ec1ca6a0b 100644 --- a/test/unit/python/sample_files/write_init_files/physics_inputs_host_var.F90 +++ b/test/unit/python/sample_files/write_init_files/physics_inputs_host_var.F90 @@ -139,7 +139,7 @@ subroutine physics_read_data(file, suite_names, timestep, read_initialized_varia case (const_idx) - ! If an index was found in the constituent hash table, then do nothing, this will be handled later + ! If an index was found in the constituent hash table, then do nothing, this will be handled later. case default @@ -313,7 +313,7 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference, case (const_idx) - ! If variable is a constituent, then do nothing. We'll handle these later + ! If variable is a constituent, then do nothing. We'll handle these later. case (init_mark_idx) diff --git a/test/unit/python/sample_files/write_init_files/physics_inputs_initial_value.F90 b/test/unit/python/sample_files/write_init_files/physics_inputs_initial_value.F90 index 01424c1bd..2a460d699 100644 --- a/test/unit/python/sample_files/write_init_files/physics_inputs_initial_value.F90 +++ b/test/unit/python/sample_files/write_init_files/physics_inputs_initial_value.F90 @@ -139,7 +139,7 @@ subroutine physics_read_data(file, suite_names, timestep, read_initialized_varia case (const_idx) - ! If an index was found in the constituent hash table, then do nothing, this will be handled later + ! If an index was found in the constituent hash table, then do nothing, this will be handled later. case default @@ -317,7 +317,7 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference, case (const_idx) - ! If variable is a constituent, then do nothing. We'll handle these later + ! If variable is a constituent, then do nothing. We'll handle these later. case (init_mark_idx) diff --git a/test/unit/python/sample_files/write_init_files/physics_inputs_mf.F90 b/test/unit/python/sample_files/write_init_files/physics_inputs_mf.F90 index 678021e4d..8fc4f7d49 100644 --- a/test/unit/python/sample_files/write_init_files/physics_inputs_mf.F90 +++ b/test/unit/python/sample_files/write_init_files/physics_inputs_mf.F90 @@ -140,7 +140,7 @@ subroutine physics_read_data(file, suite_names, timestep, read_initialized_varia case (const_idx) - ! If an index was found in the constituent hash table, then do nothing, this will be handled later + ! If an index was found in the constituent hash table, then do nothing, this will be handled later. case default @@ -318,7 +318,7 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference, case (const_idx) - ! If variable is a constituent, then do nothing. We'll handle these later + ! If variable is a constituent, then do nothing. We'll handle these later. case (init_mark_idx) diff --git a/test/unit/python/sample_files/write_init_files/physics_inputs_no_horiz.F90 b/test/unit/python/sample_files/write_init_files/physics_inputs_no_horiz.F90 index 7e855e14b..a44bd1f77 100644 --- a/test/unit/python/sample_files/write_init_files/physics_inputs_no_horiz.F90 +++ b/test/unit/python/sample_files/write_init_files/physics_inputs_no_horiz.F90 @@ -139,7 +139,7 @@ subroutine physics_read_data(file, suite_names, timestep, read_initialized_varia case (const_idx) - ! If an index was found in the constituent hash table, then do nothing, this will be handled later + ! If an index was found in the constituent hash table, then do nothing, this will be handled later. case default @@ -317,7 +317,7 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference, case (const_idx) - ! If variable is a constituent, then do nothing. We'll handle these later + ! If variable is a constituent, then do nothing. We'll handle these later. case (init_mark_idx) diff --git a/test/unit/python/sample_files/write_init_files/physics_inputs_noreq.F90 b/test/unit/python/sample_files/write_init_files/physics_inputs_noreq.F90 index 8cb1892bf..6f64e83e5 100644 --- a/test/unit/python/sample_files/write_init_files/physics_inputs_noreq.F90 +++ b/test/unit/python/sample_files/write_init_files/physics_inputs_noreq.F90 @@ -138,7 +138,7 @@ subroutine physics_read_data(file, suite_names, timestep, read_initialized_varia case (const_idx) - ! If an index was found in the constituent hash table, then do nothing, this will be handled later + ! If an index was found in the constituent hash table, then do nothing, this will be handled later. case default @@ -309,7 +309,7 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference, case (const_idx) - ! If variable is a constituent, then do nothing. We'll handle these later + ! If variable is a constituent, then do nothing. We'll handle these later. case (init_mark_idx) diff --git a/test/unit/python/sample_files/write_init_files/physics_inputs_param.F90 b/test/unit/python/sample_files/write_init_files/physics_inputs_param.F90 index e7cd79f03..3ea2ff058 100644 --- a/test/unit/python/sample_files/write_init_files/physics_inputs_param.F90 +++ b/test/unit/python/sample_files/write_init_files/physics_inputs_param.F90 @@ -139,7 +139,7 @@ subroutine physics_read_data(file, suite_names, timestep, read_initialized_varia case (const_idx) - ! If an index was found in the constituent hash table, then do nothing, this will be handled later + ! If an index was found in the constituent hash table, then do nothing, this will be handled later. case default @@ -320,7 +320,7 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference, case (const_idx) - ! If variable is a constituent, then do nothing. We'll handle these later + ! If variable is a constituent, then do nothing. We'll handle these later. case (init_mark_idx) diff --git a/test/unit/python/sample_files/write_init_files/physics_inputs_protect.F90 b/test/unit/python/sample_files/write_init_files/physics_inputs_protect.F90 index b8baaa0cb..917d2031f 100644 --- a/test/unit/python/sample_files/write_init_files/physics_inputs_protect.F90 +++ b/test/unit/python/sample_files/write_init_files/physics_inputs_protect.F90 @@ -139,7 +139,7 @@ subroutine physics_read_data(file, suite_names, timestep, read_initialized_varia case (const_idx) - ! If an index was found in the constituent hash table, then do nothing, this will be handled later + ! If an index was found in the constituent hash table, then do nothing, this will be handled later. case default @@ -317,7 +317,7 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference, case (const_idx) - ! If variable is a constituent, then do nothing. We'll handle these later + ! If variable is a constituent, then do nothing. We'll handle these later. case (init_mark_idx) diff --git a/test/unit/python/sample_files/write_init_files/physics_inputs_scalar.F90 b/test/unit/python/sample_files/write_init_files/physics_inputs_scalar.F90 index ef334cca5..575e87fbd 100644 --- a/test/unit/python/sample_files/write_init_files/physics_inputs_scalar.F90 +++ b/test/unit/python/sample_files/write_init_files/physics_inputs_scalar.F90 @@ -139,7 +139,7 @@ subroutine physics_read_data(file, suite_names, timestep, read_initialized_varia case (const_idx) - ! If an index was found in the constituent hash table, then do nothing, this will be handled later + ! If an index was found in the constituent hash table, then do nothing, this will be handled later. case default @@ -317,7 +317,7 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference, case (const_idx) - ! If variable is a constituent, then do nothing. We'll handle these later + ! If variable is a constituent, then do nothing. We'll handle these later. case (init_mark_idx) diff --git a/test/unit/python/sample_files/write_init_files/physics_inputs_simple.F90 b/test/unit/python/sample_files/write_init_files/physics_inputs_simple.F90 index c02efc98f..1d798e7b4 100644 --- a/test/unit/python/sample_files/write_init_files/physics_inputs_simple.F90 +++ b/test/unit/python/sample_files/write_init_files/physics_inputs_simple.F90 @@ -139,7 +139,7 @@ subroutine physics_read_data(file, suite_names, timestep, read_initialized_varia case (const_idx) - ! If an index was found in the constituent hash table, then do nothing, this will be handled later + ! If an index was found in the constituent hash table, then do nothing, this will be handled later. case default @@ -317,7 +317,7 @@ subroutine physics_check_data(file_name, suite_names, timestep, min_difference, case (const_idx) - ! If variable is a constituent, then do nothing. We'll handle these later + ! If variable is a constituent, then do nothing. We'll handle these later. case (init_mark_idx)