Skip to content

CAM-SIMA does nothing if hist_* fields are mis-typed. #510

Description

@nusbaume

What happened?

If a user add a hist_* field to user_nl_cam, but types the text incorrectly (in my test case hist_add_average_fields was used instead of hist_add_avg_fields), the model will throw no error or warning and then fully run to completion with no model output. This means there is a risk that a simple typo could result in a user wasting large amounts of computer time with no model output.

What are the steps to reproduce the bug?

Run a CAM-SIMA simulation with a typo in a hist_add_* key in user_nl_cam., and find that no outputs are generated for that output type.

What CAM-SIMA hash were you using?

ea83252

What machine were you running CAM-SIMA on?

CISL machine (e.g. cheyenne)

What compiler were you using?

GNU

Path to a case directory, if applicable

No response

Will you be addressing this bug yourself?

Any Software Engineer can do this

Extra info

I believe a simple fix could be to create a set of all accepted hist_ namelist entries, and then if anything is found that starts with hist_ but doesn't match anything in the set an error is thrown at preview_namelist time.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working correctly

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions