Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QC.Sty: Missing Python flake8 compliant check? #107

Open
rjdmartins opened this issue Oct 24, 2022 · 2 comments
Open

QC.Sty: Missing Python flake8 compliant check? #107

rjdmartins opened this issue Oct 24, 2022 · 2 comments

Comments

@rjdmartins
Copy link

rjdmartins commented Oct 24, 2022

On October 20th, we released the public version of WORSICA with python code and then run the online assessment for badging. We got the silver badge, but the report showed us the following problems in Qc.Sty (Code Style), image below:

  • Python files are not fully complaint with flake8 standard
  • Javascript files are not fully complaint with stylelint standard
    image

Today, October 24th, we released a new public version of WORSICA to make python files flake8 complaint, and run again the online assessment. We got again the silver badge, but the report didn't show if Python files are complaint or not with flake8. Image below:
image

Can you confirm if this check was removed from the assessment recently, or is it a bug?
We can't achieve the gold badge because of this limitation.

@orviz
Copy link
Contributor

orviz commented Nov 15, 2022

@rjdmartins the issue with flake8 is solved so the message should always appear. I don't have the link of your repo so I cannot assure it.

About JavaScript, it would be helpful if you can share the output from Jenkins.

@rjdmartins
Copy link
Author

rjdmartins commented Nov 16, 2022

@orviz I tested flake8 using the repo https://github.com/WORSICA/eosc-worsica-processing, and now it's fixed.

About JS, this does not apply to eosc-worsica-processing because that repository does not have any JS/VUE files. Check the issue #108.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants