Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added product query in the URL #227

Closed
wants to merge 2 commits into from

Conversation

codetheorem
Copy link
Member

@codetheorem codetheorem commented Apr 5, 2022

Signed-off-by: Hrishikesh Agarwal [email protected]

Issue Number

fixes #228

Describe the changes you've made

I have added product query string in the URL ?product=name now with this wherever, the productlist string will be used it will update that. On the story page there is product image in that I have added a link that redirects to home with product query.

Additional context (OPTIONAL)

I have added query-string package for parsing location search string

Test plan (OPTIONAL)

  1. Visit home page
  2. Click on any story
  3. On the story page click the product image
  4. Change product on the home page and see URL

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • The title of my pull request is a short description of the requested changes.

Signed-off-by: Hrishikesh Agarwal <[email protected]>
@kaybhutani
Copy link
Member

resolve conflicts please @codetheorem

Signed-off-by: Hrishikesh Agarwal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add redirect link on story page for product
2 participants